immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-23 21:35:55 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2342] [MERGED] refactor(server): facial recognition #9507

New Issue
Closed
opened 2026-02-05 14:05:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:05:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2342
Author: @jrasm91
Created: 4/27/2023
Status: ✅ Merged
Merged: 4/27/2023
Merged by: @alextran1502

Base: feat/facial-recognition ← Head: refactor/facial-recognition-processing

📝 Commits (6)

📊 Changes

29 files changed (+8992 additions, -10357 deletions)

View changed files

➖ machine-learning/src/face_processor.py (+0 -143)
📝 machine-learning/src/main.py (+44 -16)
📝 mobile/openapi/.openapi-generator/FILES (+3 -0)
📝 mobile/openapi/README.md (+1 -0)
📝 mobile/openapi/doc/AssetResponseDto.md (+1 -0)
➕ mobile/openapi/doc/PersonResponseDto.md (+17 -0)
📝 mobile/openapi/lib/api.dart (+1 -0)
📝 mobile/openapi/lib/api_client.dart (+2 -0)
📝 mobile/openapi/lib/model/asset_response_dto.dart (+10 -3)
➕ mobile/openapi/lib/model/person_response_dto.dart (+127 -0)
📝 mobile/openapi/test/asset_response_dto_test.dart (+5 -0)
➕ mobile/openapi/test/person_response_dto_test.dart (+37 -0)
📝 server/apps/immich/src/api-v1/asset/asset-repository.ts (+1 -1)
📝 server/apps/microservices/src/processors.ts (+6 -0)
📝 server/immich-openapi-specs.json (+25 -0)
📝 server/libs/domain/src/asset/response-dto/asset-response.dto.ts (+19 -2)
📝 server/libs/domain/src/facial-recognition/facial-recognition.repository.ts (+3 -1)
📝 server/libs/domain/src/facial-recognition/facial-recognition.services.ts (+41 -64)
📝 server/libs/domain/src/job/job.constants.ts (+1 -0)
📝 server/libs/domain/src/job/job.interface.ts (+7 -0)

...and 9 more files

📄 Description

  • Clean up python code
  • Separate job for generating people thumbnails
  • Return people in asset detail

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2342 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 4/27/2023 **Status:** ✅ Merged **Merged:** 4/27/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `feat/facial-recognition` ← **Head:** `refactor/facial-recognition-processing` --- ### 📝 Commits (6) - [`8943f8a`](https://github.com/immich-app/immich/commit/8943f8afa7823aaa88e449ecc39f7a974acbf05d) refactor: face processor - [`15bb5b6`](https://github.com/immich-app/immich/commit/15bb5b654f726cc055a9dfd1145292941ab2a83c) fix: without _faces_ - [`63c859f`](https://github.com/immich-app/immich/commit/63c859f54094e044e980ba00154ff79ab0c04244) chore: logging - [`422b839`](https://github.com/immich-app/immich/commit/422b839149544365cb96f8933b23d5e06a94ca27) refactor: face processing - [`a7ded37`](https://github.com/immich-app/immich/commit/a7ded37788750962985a4a4d7473ce9ca174ed22) chore: open api - [`1205889`](https://github.com/immich-app/immich/commit/12058898579db46316b5297def0e621beee75381) fix: bugs ### 📊 Changes **29 files changed** (+8992 additions, -10357 deletions) <details> <summary>View changed files</summary> ➖ `machine-learning/src/face_processor.py` (+0 -143) 📝 `machine-learning/src/main.py` (+44 -16) 📝 `mobile/openapi/.openapi-generator/FILES` (+3 -0) 📝 `mobile/openapi/README.md` (+1 -0) 📝 `mobile/openapi/doc/AssetResponseDto.md` (+1 -0) ➕ `mobile/openapi/doc/PersonResponseDto.md` (+17 -0) 📝 `mobile/openapi/lib/api.dart` (+1 -0) 📝 `mobile/openapi/lib/api_client.dart` (+2 -0) 📝 `mobile/openapi/lib/model/asset_response_dto.dart` (+10 -3) ➕ `mobile/openapi/lib/model/person_response_dto.dart` (+127 -0) 📝 `mobile/openapi/test/asset_response_dto_test.dart` (+5 -0) ➕ `mobile/openapi/test/person_response_dto_test.dart` (+37 -0) 📝 `server/apps/immich/src/api-v1/asset/asset-repository.ts` (+1 -1) 📝 `server/apps/microservices/src/processors.ts` (+6 -0) 📝 `server/immich-openapi-specs.json` (+25 -0) 📝 `server/libs/domain/src/asset/response-dto/asset-response.dto.ts` (+19 -2) 📝 `server/libs/domain/src/facial-recognition/facial-recognition.repository.ts` (+3 -1) 📝 `server/libs/domain/src/facial-recognition/facial-recognition.services.ts` (+41 -64) 📝 `server/libs/domain/src/job/job.constants.ts` (+1 -0) 📝 `server/libs/domain/src/job/job.interface.ts` (+7 -0) _...and 9 more files_ </details> ### 📄 Description * Clean up python code * Separate job for generating people thumbnails * Return people in asset detail --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:05:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?