immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2278] [MERGED] fix(web): noscript message #9477

New Issue
Closed
opened 2026-02-05 14:05:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:05:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2278
Author: @michelheusschen
Created: 4/18/2023
Status: ✅ Merged
Merged: 4/18/2023
Merged by: @alextran1502

Base: main ← Head: fix/web-noscript-message

📝 Commits (1)

  • 9895f92 fix(web): noscript message

📊 Changes

2 files changed (+9 additions, -26 deletions)

View changed files

📝 web/src/app.html (+0 -26)
📝 web/src/routes/+layout.svelte (+9 -0)

📄 Description

#2274 added a noscript message, but the image won't show in production builds because only assets in the static folder are copied to the production build. The noscript element was added to app.html, but since SvelteKit does SSR the message can be added to the root layout and use existing components.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2278 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 4/18/2023 **Status:** ✅ Merged **Merged:** 4/18/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/web-noscript-message` --- ### 📝 Commits (1) - [`9895f92`](https://github.com/immich-app/immich/commit/9895f921c6c2bebe02ea17e355e34470ae9a996d) fix(web): noscript message ### 📊 Changes **2 files changed** (+9 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `web/src/app.html` (+0 -26) 📝 `web/src/routes/+layout.svelte` (+9 -0) </details> ### 📄 Description #2274 added a noscript message, but the image won't show in production builds because only assets in the `static` folder are copied to the production build. The noscript element was added to `app.html`, but since SvelteKit does SSR the message can be added to the root layout and use existing components. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:05:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?