immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2237] [MERGED] feat: Add description #9453

New Issue
Closed
opened 2026-02-05 14:05:01 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:05:01 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2237
Author: @alextran1502
Created: 4/12/2023
Status: ✅ Merged
Merged: 4/13/2023
Merged by: @alextran1502

Base: main ← Head: feat/add-description

📝 Commits (10+)

  • 5dc8c8b Added dto, logic to insert description and web implementation
  • 0730fc0 create text field and update on remote database
  • 09960c1 Update description and save changes
  • e08a1b5 styling
  • 8b95649 fix web test
  • ceac128 fix server test
  • 72def10 preserve description on metadata extraction job run
  • f0cacfd handle exif info is null situation
  • c20ac68 pr feedback
  • fb7dc2f Merge branch 'main' of github.com:immich-app/immich into feat/add-description

📊 Changes

27 files changed (+843 additions, -178 deletions)

View changed files

📝 mobile/assets/i18n/en-US.json (+7 -1)
➕ mobile/flutter_01.png (+0 -0)
➕ mobile/lib/modules/asset_viewer/providers/asset_description.provider.dart (+93 -0)
➕ mobile/lib/modules/asset_viewer/services/asset_description.service.dart (+62 -0)
➕ mobile/lib/modules/asset_viewer/ui/description_input.dart (+103 -0)
📝 mobile/lib/modules/asset_viewer/ui/exif_bottom_sheet.dart (+119 -101)
📝 mobile/lib/modules/asset_viewer/views/gallery_viewer.dart (+6 -1)
📝 mobile/lib/modules/settings/ui/advanced_settings/advanced_settings.dart (+11 -4)
📝 mobile/lib/shared/models/exif_info.dart (+4 -1)
📝 mobile/lib/shared/models/exif_info.g.dart (+243 -42)
📝 mobile/openapi/doc/ExifResponseDto.md (+1 -0)
📝 mobile/openapi/doc/UpdateAssetDto.md (+1 -0)
📝 mobile/openapi/lib/model/exif_response_dto.dart (+14 -3)
📝 mobile/openapi/lib/model/update_asset_dto.dart (+20 -3)
📝 mobile/openapi/test/exif_response_dto_test.dart (+5 -0)
📝 mobile/openapi/test/update_asset_dto_test.dart (+5 -0)
📝 server/apps/immich/src/api-v1/asset/asset-repository.ts (+13 -1)
📝 server/apps/immich/src/api-v1/asset/asset.module.ts (+2 -2)
📝 server/apps/immich/src/api-v1/asset/dto/update-asset.dto.ts (+4 -0)
📝 server/apps/microservices/src/processors/metadata-extraction.processor.ts (+0 -1)

...and 7 more files

📄 Description

Description

This PR adds the "description" mechanism to the asset. It is functional on both the web and the mobile app.

  • Edit some styling for the exif bottom app bar on the mobile app.
  • Using the same style input as GPhotos, no submit button needed, unfocus will save the description
  • User can search for asset with description using the metadata search syntax m:description
qemu-system-x86_64_lgg9uS1PpL

Fixes # (issue)

How Has This Been Tested?

  • From the blank description on both the mobile app and the web, edit the description field and check the value after navigating back and forth between the web and the mobile app to ensure the value is persistent.
  • View and edit description from owned and shared albums with mixed of assets from the owner and the shared user
  • View and edit description from a shared link with mixed of assets from the owner and the shared user

Screenshots (if appropriate):

qemu-system-x86_64_lgg9uS1PpL

qemu-system-x86_64_lgg9uS1PpL

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2237 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 4/12/2023 **Status:** ✅ Merged **Merged:** 4/13/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feat/add-description` --- ### 📝 Commits (10+) - [`5dc8c8b`](https://github.com/immich-app/immich/commit/5dc8c8b3decdae40aee115a4bcbc45932c98fdcd) Added dto, logic to insert description and web implementation - [`0730fc0`](https://github.com/immich-app/immich/commit/0730fc00a57652170bff2d1fab1c501a21ed8e72) create text field and update on remote database - [`09960c1`](https://github.com/immich-app/immich/commit/09960c1230cf3cb5e930c2f6ae5dcaeb8a01aa4d) Update description and save changes - [`e08a1b5`](https://github.com/immich-app/immich/commit/e08a1b51e2b976f20aba8f1f97ec2ae33b023159) styling - [`8b95649`](https://github.com/immich-app/immich/commit/8b9564999532a63eb1034fa0d6f4a6bfbd01afea) fix web test - [`ceac128`](https://github.com/immich-app/immich/commit/ceac1281518da5d343a652f10d9aad6a2ab9a749) fix server test - [`72def10`](https://github.com/immich-app/immich/commit/72def10ca9947a45209360086f9b28ec9f6101a3) preserve description on metadata extraction job run - [`f0cacfd`](https://github.com/immich-app/immich/commit/f0cacfdb94b79a0d73579654b92aaf99bcc255c1) handle exif info is null situation - [`c20ac68`](https://github.com/immich-app/immich/commit/c20ac68c8af048fe2d717b394decb80ac12f204e) pr feedback - [`fb7dc2f`](https://github.com/immich-app/immich/commit/fb7dc2f28056a113660aa69163724282d7e996d3) Merge branch 'main' of github.com:immich-app/immich into feat/add-description ### 📊 Changes **27 files changed** (+843 additions, -178 deletions) <details> <summary>View changed files</summary> 📝 `mobile/assets/i18n/en-US.json` (+7 -1) ➕ `mobile/flutter_01.png` (+0 -0) ➕ `mobile/lib/modules/asset_viewer/providers/asset_description.provider.dart` (+93 -0) ➕ `mobile/lib/modules/asset_viewer/services/asset_description.service.dart` (+62 -0) ➕ `mobile/lib/modules/asset_viewer/ui/description_input.dart` (+103 -0) 📝 `mobile/lib/modules/asset_viewer/ui/exif_bottom_sheet.dart` (+119 -101) 📝 `mobile/lib/modules/asset_viewer/views/gallery_viewer.dart` (+6 -1) 📝 `mobile/lib/modules/settings/ui/advanced_settings/advanced_settings.dart` (+11 -4) 📝 `mobile/lib/shared/models/exif_info.dart` (+4 -1) 📝 `mobile/lib/shared/models/exif_info.g.dart` (+243 -42) 📝 `mobile/openapi/doc/ExifResponseDto.md` (+1 -0) 📝 `mobile/openapi/doc/UpdateAssetDto.md` (+1 -0) 📝 `mobile/openapi/lib/model/exif_response_dto.dart` (+14 -3) 📝 `mobile/openapi/lib/model/update_asset_dto.dart` (+20 -3) 📝 `mobile/openapi/test/exif_response_dto_test.dart` (+5 -0) 📝 `mobile/openapi/test/update_asset_dto_test.dart` (+5 -0) 📝 `server/apps/immich/src/api-v1/asset/asset-repository.ts` (+13 -1) 📝 `server/apps/immich/src/api-v1/asset/asset.module.ts` (+2 -2) 📝 `server/apps/immich/src/api-v1/asset/dto/update-asset.dto.ts` (+4 -0) 📝 `server/apps/microservices/src/processors/metadata-extraction.processor.ts` (+0 -1) _...and 7 more files_ </details> ### 📄 Description ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> This PR adds the "description" mechanism to the asset. It is functional on both the web and the mobile app. - Edit some styling for the exif bottom app bar on the mobile app. - Using the same style input as GPhotos, no submit button needed, unfocus will save the description - User can search for asset with description using the metadata search syntax `m:description` <img width="399" alt="qemu-system-x86_64_lgg9uS1PpL" src="https://user-images.githubusercontent.com/27055614/231323681-e3380760-ecbf-45c2-8648-f6586e7b539f.png"> Fixes # (issue) ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] From the blank description on both the mobile app and the web, edit the description field and check the value after navigating back and forth between the web and the mobile app to ensure the value is persistent. - [x] View and edit description from owned and shared albums with mixed of assets from the owner and the shared user - [x] View and edit description from a shared link with mixed of assets from the owner and the shared user ## Screenshots (if appropriate): <img alt="qemu-system-x86_64_lgg9uS1PpL" src="https://user-images.githubusercontent.com/27055614/231323591-bd1c99a1-a1a3-4ac2-a0b0-0eb67fbe1d22.png"> <p> <img width="399" alt="qemu-system-x86_64_lgg9uS1PpL" src="https://user-images.githubusercontent.com/27055614/231323599-07248e9e-d300-4ae8-840c-469375370e29.png"> </p> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:05:01 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9453
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?