immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2232] [CLOSED] fix(server): stale path when run video encoding job #9447

New Issue
Closed
opened 2026-02-05 14:04:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:04:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2232
Author: @alextran1502
Created: 4/11/2023
Status: ❌ Closed

Base: main ← Head: fix/stall-path-information-when-rerun-job

📝 Commits (10+)

  • 5b65a60 feat(server): add originalFileName to asset table
  • f48d447 remove imageName in Exif table and use originalFileName in asset table
  • 86724d9 use originalFileName accross search and web app
  • a34d0c2 use originalFileName accross search and web app
  • 109c6c8 Update typesense search query
  • 07b83b3 Make originalFileName not null
  • 79dbb01 update migration
  • 9462132 update migration
  • 25602c3 fix test
  • 3484a4c change migration order for imagename

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 server/libs/domain/src/media/media.service.ts (+6 -1)

📄 Description

Description

Note: branch open from #2231

Fixed issue when video extract exif job executes first and moves the asset to the correct location, then the video encoding job executes later and uses stale data with the path before being moved lead to a failed job.

How Has This Been Tested?

  • Upload LivePhotos in bulk and make sure that there is no failed video conversion

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2232 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 4/11/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/stall-path-information-when-rerun-job` --- ### 📝 Commits (10+) - [`5b65a60`](https://github.com/immich-app/immich/commit/5b65a6094a4e4ad71ce745c7dbad4ba34104e13c) feat(server): add originalFileName to asset table - [`f48d447`](https://github.com/immich-app/immich/commit/f48d44755bf5e952f30d2c09c396163c9ca895b4) remove imageName in Exif table and use originalFileName in asset table - [`86724d9`](https://github.com/immich-app/immich/commit/86724d9dee7b578be0b5d45692fb484c52114f0b) use originalFileName accross search and web app - [`a34d0c2`](https://github.com/immich-app/immich/commit/a34d0c2566c9d6efe33c75838d1a1d330c95e764) use originalFileName accross search and web app - [`109c6c8`](https://github.com/immich-app/immich/commit/109c6c8758268f1d5940fde41cdb6e03ce6e06be) Update typesense search query - [`07b83b3`](https://github.com/immich-app/immich/commit/07b83b3519b0d9ed334e303e80b159550b913a44) Make originalFileName not null - [`79dbb01`](https://github.com/immich-app/immich/commit/79dbb016859f95d2065881afd62cf20d6e39c3b0) update migration - [`9462132`](https://github.com/immich-app/immich/commit/9462132898477030a66b8db2705995c52e59ee33) update migration - [`25602c3`](https://github.com/immich-app/immich/commit/25602c31ccd5bfc7ff9e07acbc7bb47d41d9946c) fix test - [`3484a4c`](https://github.com/immich-app/immich/commit/3484a4cbd80f7fc9de05b4ff254d39fb58faafc5) change migration order for imagename ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/libs/domain/src/media/media.service.ts` (+6 -1) </details> ### 📄 Description ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> **Note: branch open from #2231** Fixed issue when video extract exif job executes first and moves the asset to the correct location, then the video encoding job executes later and uses stale data with the path before being moved lead to a failed job. ## How Has This Been Tested? - [x] Upload LivePhotos in bulk and make sure that there is no failed video conversion ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:04:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9447
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?