immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2200] [MERGED] refactor(web): centralize buttons #9430

New Issue
Closed
opened 2026-02-05 14:04:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:04:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2200
Author: @michelheusschen
Created: 4/7/2023
Status: ✅ Merged
Merged: 4/7/2023
Merged by: @alextran1502

Base: main ← Head: refactor/web-buttons

📝 Commits (1)

  • 5001410 refactor(web): centralize buttons

📊 Changes

42 files changed (+248 additions, -242 deletions)

View changed files

📝 web/src/app.css (+0 -17)
📝 web/src/lib/components/admin-page/delete-confirm-dialoge.svelte (+2 -5)
📝 web/src/lib/components/admin-page/restore-dialoge.svelte (+2 -5)
📝 web/src/lib/components/admin-page/settings/setting-buttons-row.svelte (+3 -12)
📝 web/src/lib/components/album-page/album-card.svelte (+1 -1)
📝 web/src/lib/components/album-page/album-viewer.svelte (+7 -4)
📝 web/src/lib/components/album-page/asset-selection.svelte (+6 -3)
📝 web/src/lib/components/album-page/share-info-modal.svelte (+1 -1)
📝 web/src/lib/components/album-page/thumbnail-selection.svelte (+6 -3)
📝 web/src/lib/components/album-page/user-selection-modal.svelte (+4 -5)
📝 web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte (+1 -1)
➕ web/src/lib/components/elements/buttons/button.svelte (+71 -0)
📝 web/src/lib/components/elements/buttons/circle-icon-button.svelte (+1 -4)
➕ web/src/lib/components/elements/buttons/icon-button.svelte (+14 -0)
➕ web/src/lib/components/elements/buttons/link-button.svelte (+13 -0)
📝 web/src/lib/components/forms/admin-registration-form.svelte (+2 -1)
📝 web/src/lib/components/forms/api-key-form.svelte (+3 -11)
📝 web/src/lib/components/forms/api-key-secret.svelte (+3 -10)
📝 web/src/lib/components/forms/change-password-form.svelte (+2 -1)
📝 web/src/lib/components/forms/create-user-form.svelte (+3 -7)

...and 22 more files

📄 Description

Refactors buttons with a couple of reusable components. Previously, a lot of slightly different buttons were used leading to maintainability and consistency issues. I've tried to keep the amount of visual changes to a minimum, but there are some small changes especially between light/dark mode, hover and disabled state.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2200 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 4/7/2023 **Status:** ✅ Merged **Merged:** 4/7/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/web-buttons` --- ### 📝 Commits (1) - [`5001410`](https://github.com/immich-app/immich/commit/50014109049708d5353e8737aae4250ec8aaa7ae) refactor(web): centralize buttons ### 📊 Changes **42 files changed** (+248 additions, -242 deletions) <details> <summary>View changed files</summary> 📝 `web/src/app.css` (+0 -17) 📝 `web/src/lib/components/admin-page/delete-confirm-dialoge.svelte` (+2 -5) 📝 `web/src/lib/components/admin-page/restore-dialoge.svelte` (+2 -5) 📝 `web/src/lib/components/admin-page/settings/setting-buttons-row.svelte` (+3 -12) 📝 `web/src/lib/components/album-page/album-card.svelte` (+1 -1) 📝 `web/src/lib/components/album-page/album-viewer.svelte` (+7 -4) 📝 `web/src/lib/components/album-page/asset-selection.svelte` (+6 -3) 📝 `web/src/lib/components/album-page/share-info-modal.svelte` (+1 -1) 📝 `web/src/lib/components/album-page/thumbnail-selection.svelte` (+6 -3) 📝 `web/src/lib/components/album-page/user-selection-modal.svelte` (+4 -5) 📝 `web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte` (+1 -1) ➕ `web/src/lib/components/elements/buttons/button.svelte` (+71 -0) 📝 `web/src/lib/components/elements/buttons/circle-icon-button.svelte` (+1 -4) ➕ `web/src/lib/components/elements/buttons/icon-button.svelte` (+14 -0) ➕ `web/src/lib/components/elements/buttons/link-button.svelte` (+13 -0) 📝 `web/src/lib/components/forms/admin-registration-form.svelte` (+2 -1) 📝 `web/src/lib/components/forms/api-key-form.svelte` (+3 -11) 📝 `web/src/lib/components/forms/api-key-secret.svelte` (+3 -10) 📝 `web/src/lib/components/forms/change-password-form.svelte` (+2 -1) 📝 `web/src/lib/components/forms/create-user-form.svelte` (+3 -7) _...and 22 more files_ </details> ### 📄 Description Refactors buttons with a couple of reusable components. Previously, a lot of slightly different buttons were used leading to maintainability and consistency issues. I've tried to keep the amount of visual changes to a minimum, but there are some small changes especially between light/dark mode, hover and disabled state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:04:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?