immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2157] [MERGED] chore(docker): Default NODE_ENV to production for server image and update alpine version #9402

New Issue
Closed
opened 2026-02-05 14:04:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:04:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2157
Author: @onedr0p
Created: 4/3/2023
Status: ✅ Merged
Merged: 4/3/2023
Merged by: @alextran1502

Base: main ← Head: docker-updates

📝 Commits (5)

  • 563569a default NODE_ENV to production for server image
  • a6ac2e3 update node image to use 3.17 alpine in server
  • 8a0a536 update web docker image to use alpine 3.17
  • e5bbb89 remove NODE_ENV from production docker-compose
  • 1738b33 NODE_ENV is also needed default in machine-learning

📊 Changes

4 files changed (+7 additions, -9 deletions)

View changed files

📝 docker/docker-compose.yml (+0 -6)
📝 machine-learning/Dockerfile (+2 -0)
📝 server/Dockerfile (+4 -2)
📝 web/Dockerfile (+1 -1)

📄 Description

This PR sets the NODE_ENV to production in the server image, this ENV is already set on the web container so it could be set here as well.

I have also updated the alpine version to 3.17 (previously 3.14) off node 16

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2157 **Author:** [@onedr0p](https://github.com/onedr0p) **Created:** 4/3/2023 **Status:** ✅ Merged **Merged:** 4/3/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `docker-updates` --- ### 📝 Commits (5) - [`563569a`](https://github.com/immich-app/immich/commit/563569a0ed2a632eadcc3bfa735de9bcd653a27a) default NODE_ENV to production for server image - [`a6ac2e3`](https://github.com/immich-app/immich/commit/a6ac2e3c40ffbdd0f6135a3701a8d69aed4ed4d7) update node image to use 3.17 alpine in server - [`8a0a536`](https://github.com/immich-app/immich/commit/8a0a536874e212d39379e68617a08e403e3e5c29) update web docker image to use alpine 3.17 - [`e5bbb89`](https://github.com/immich-app/immich/commit/e5bbb899ccdec422cc9e20d2dca681b1c4322e0a) remove NODE_ENV from production docker-compose - [`1738b33`](https://github.com/immich-app/immich/commit/1738b33fd9da9eb43984a3a944b6b038c5b04cc0) NODE_ENV is also needed default in machine-learning ### 📊 Changes **4 files changed** (+7 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `docker/docker-compose.yml` (+0 -6) 📝 `machine-learning/Dockerfile` (+2 -0) 📝 `server/Dockerfile` (+4 -2) 📝 `web/Dockerfile` (+1 -1) </details> ### 📄 Description This PR sets the `NODE_ENV` to `production` in the server image, this ENV is already set on the web container so it could be set here as well. I have also updated the alpine version to 3.17 (previously 3.14) off node 16 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:04:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?