immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-24 19:08:04 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #1998] [MERGED] feat(web): bundle and 'sveltify' leaflet #9315

New Issue
Closed
opened 2026-02-05 14:02:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:02:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1998
Author: @michelheusschen
Created: 3/14/2023
Status: ✅ Merged
Merged: 3/19/2023
Merged by: @alextran1502

Base: main ← Head: feat/web-leaflet

📝 Commits (3)

  • 2daed91 feat(web): bundle and 'sveltify' leaflet
  • c1d99f3 lazy load leaflet components
  • e0007ba add correct icon sizes

📊 Changes

6 files changed (+142 additions, -52 deletions)

View changed files

📝 web/src/lib/components/asset-viewer/detail-panel.svelte (+24 -52)
➕ web/src/lib/components/shared-components/leaflet/index.ts (+3 -0)
➕ web/src/lib/components/shared-components/leaflet/map.svelte (+42 -0)
➕ web/src/lib/components/shared-components/leaflet/marker.svelte (+46 -0)
➕ web/src/lib/components/shared-components/leaflet/tile-layer.svelte (+19 -0)
➕ web/src/lib/utils/context.ts (+8 -0)

📄 Description

Bundled Leaflet CSS to prevent loading it from the unpkg CDN, closes #1191. I've also created Svelte components for using Leaflet. Lastly, the zoom level has been changed from 17 to 14 for a more generalized and zoomed-out view of the map. This value is pretty arbitrary and can be discussed/changed further, but I think seeing the general area is more important than the exact building.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1998 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 3/14/2023 **Status:** ✅ Merged **Merged:** 3/19/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feat/web-leaflet` --- ### 📝 Commits (3) - [`2daed91`](https://github.com/immich-app/immich/commit/2daed911ed035b4383969cf3df44014afc1dfac1) feat(web): bundle and 'sveltify' leaflet - [`c1d99f3`](https://github.com/immich-app/immich/commit/c1d99f3acb2a6c994b264dc53697fd6a066db4dd) lazy load leaflet components - [`e0007ba`](https://github.com/immich-app/immich/commit/e0007ba3316b9c1e7ea946ec11e032f4204d2cb7) add correct icon sizes ### 📊 Changes **6 files changed** (+142 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/asset-viewer/detail-panel.svelte` (+24 -52) ➕ `web/src/lib/components/shared-components/leaflet/index.ts` (+3 -0) ➕ `web/src/lib/components/shared-components/leaflet/map.svelte` (+42 -0) ➕ `web/src/lib/components/shared-components/leaflet/marker.svelte` (+46 -0) ➕ `web/src/lib/components/shared-components/leaflet/tile-layer.svelte` (+19 -0) ➕ `web/src/lib/utils/context.ts` (+8 -0) </details> ### 📄 Description Bundled Leaflet CSS to prevent loading it from the unpkg CDN, closes #1191. I've also created Svelte components for using Leaflet. Lastly, the zoom level has been changed from `17` to `14` for a more generalized and zoomed-out view of the map. This value is pretty arbitrary and can be discussed/changed further, but I think seeing the general area is more important than the exact building. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:02:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9315
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?