immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1936] [MERGED] fix(web): nested layout navigation issue #9292

New Issue
Closed
opened 2026-02-05 14:02:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:02:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1936
Author: @alextran1502
Created: 3/4/2023
Status: ✅ Merged
Merged: 3/5/2023
Merged by: @alextran1502

Base: main ← Head: fix/web-nested-layout-issue

📝 Commits (3)

  • 834b4e8 fix(web): nested layout navigation issue
  • c0a100a move guarding to html template
  • 4f38e73 fix test

📊 Changes

4 files changed (+1067 additions, -722 deletions)

View changed files

📝 web/package-lock.json (+1043 -695)
📝 web/src/lib/components/shared-components/drag-and-drop-upload-overlay.svelte (+5 -4)
➖ web/src/routes/(user)/+layout.svelte (+0 -22)
📝 web/src/routes/+layout.svelte (+19 -1)

📄 Description

  • Update SvelteKit version
  • Remove (user)/+layout.svelte since it causes problem with navigation
  • Add guard to drag-n-drop overlay to only show in (user) route id

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1936 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 3/4/2023 **Status:** ✅ Merged **Merged:** 3/5/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/web-nested-layout-issue` --- ### 📝 Commits (3) - [`834b4e8`](https://github.com/immich-app/immich/commit/834b4e88dfae3be0b1e23fe08fc652a637d945f8) fix(web): nested layout navigation issue - [`c0a100a`](https://github.com/immich-app/immich/commit/c0a100a51c988b1ed85d0ace5aebaf2c9a07f371) move guarding to html template - [`4f38e73`](https://github.com/immich-app/immich/commit/4f38e73ab7ab0bd420b71aa8cb769e31aba9fcbc) fix test ### 📊 Changes **4 files changed** (+1067 additions, -722 deletions) <details> <summary>View changed files</summary> 📝 `web/package-lock.json` (+1043 -695) 📝 `web/src/lib/components/shared-components/drag-and-drop-upload-overlay.svelte` (+5 -4) ➖ `web/src/routes/(user)/+layout.svelte` (+0 -22) 📝 `web/src/routes/+layout.svelte` (+19 -1) </details> ### 📄 Description * Update SvelteKit version * Remove (user)/+layout.svelte since it causes problem with navigation * Add guard to drag-n-drop overlay to only show in (user) route id --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:02:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9292
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?