immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1916] [MERGED] Feat/ml image optimisations #9282

New Issue
Closed
opened 2026-02-05 14:01:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:01:52 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1916
Author: @ollywelch
Created: 3/2/2023
Status: ✅ Merged
Merged: 3/4/2023
Merged by: @alextran1502

Base: main ← Head: feat/ml-image-optimisations

📝 Commits (8)

  • 6414293 Use multi stage build to slim down ML image size
  • b4c35ea Use gunicorn as WSGI server in ML image
  • cbe9289 Configure gunicorn server for ML use case
  • 32e706c Use requirements.txt file to install python dependencies in ML image
  • c386e5c Make ML listen IP configurable
  • 9fa3297 Merge branch 'main' into feat/ml-image-optimisations
  • c1e1784 Revert "Use requirements.txt file to install python dependencies in ML image"
  • 711753c Separate out pip installs in ML builder image

📊 Changes

2 files changed (+45 additions, -10 deletions)

View changed files

📝 machine-learning/Dockerfile (+16 -10)
➕ machine-learning/gunicorn.conf.py (+29 -0)

📄 Description

Recreating this PR, as I've realised where I made a mistake. When creating the requirements.txt file I forgot to add in the --pre flag to the pip install torch, so it wasn't downloading the correct version.
I've gone back to the old format of just installing the dependencies using separate commands, I feel like a requirements file doesn't actually make things any easier here!

@alextran1502 I did manage to reproduce the error you saw by building and running on my laptop (x86_64 arch), and have confirmed that after reverting the requirements.txt changes the build works

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1916 **Author:** [@ollywelch](https://github.com/ollywelch) **Created:** 3/2/2023 **Status:** ✅ Merged **Merged:** 3/4/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feat/ml-image-optimisations` --- ### 📝 Commits (8) - [`6414293`](https://github.com/immich-app/immich/commit/6414293ffe7adff7cf8a83f0c25548de1986af0d) Use multi stage build to slim down ML image size - [`b4c35ea`](https://github.com/immich-app/immich/commit/b4c35ea57898327b0d36e73dcf13e26f52390113) Use gunicorn as WSGI server in ML image - [`cbe9289`](https://github.com/immich-app/immich/commit/cbe9289826ee301e18ed43d19f136724a49caad8) Configure gunicorn server for ML use case - [`32e706c`](https://github.com/immich-app/immich/commit/32e706c7f3db1d0aa1a66b3733ab9ec9dfb86534) Use requirements.txt file to install python dependencies in ML image - [`c386e5c`](https://github.com/immich-app/immich/commit/c386e5cbc3fbbc3adb57371d2caac0ca6cb06e9e) Make ML listen IP configurable - [`9fa3297`](https://github.com/immich-app/immich/commit/9fa32979f073ac3c23b51a950740f7442baa1c09) Merge branch 'main' into feat/ml-image-optimisations - [`c1e1784`](https://github.com/immich-app/immich/commit/c1e17849078b6919844d003be4682436575433f7) Revert "Use requirements.txt file to install python dependencies in ML image" - [`711753c`](https://github.com/immich-app/immich/commit/711753c75a86beaa65f57088a7837ca342051100) Separate out pip installs in ML builder image ### 📊 Changes **2 files changed** (+45 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `machine-learning/Dockerfile` (+16 -10) ➕ `machine-learning/gunicorn.conf.py` (+29 -0) </details> ### 📄 Description Recreating this PR, as I've realised where I made a mistake. When creating the requirements.txt file I forgot to add in the --pre flag to the pip install torch, so it wasn't downloading the correct version. I've gone back to the old format of just installing the dependencies using separate commands, I feel like a requirements file doesn't actually make things any easier here! @alextran1502 I did manage to reproduce the error you saw by building and running on my laptop (x86_64 arch), and have confirmed that after reverting the requirements.txt changes the build works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:01:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?