immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1520] [MERGED] fix(mobile): Added flutter native splash and splash screens #9118

New Issue
Closed
opened 2026-02-05 13:58:49 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:58:49 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1520
Author: @martyfuhry
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/6/2023
Merged by: @alextran1502

Base: main ← Head: chore/flutter-native-splash

📝 Commits (2)

  • e48911c rebasing
  • d1942fa added launch background image to repository

📊 Changes

43 files changed (+373 additions, -156 deletions)

View changed files

➕ mobile/android/app/src/main/res/drawable-hdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-hdpi/splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-mdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-mdpi/splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night-hdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night-mdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night-v21/background.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night-v21/launch_background.xml (+9 -0)
➕ mobile/android/app/src/main/res/drawable-night-xhdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night-xxhdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night-xxxhdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night/background.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-night/launch_background.xml (+9 -0)
➕ mobile/android/app/src/main/res/drawable-v21/background.png (+0 -0)
📝 mobile/android/app/src/main/res/drawable-v21/launch_background.xml (+6 -9)
➕ mobile/android/app/src/main/res/drawable-xhdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-xhdpi/splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-xxhdpi/android12splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-xxhdpi/splash.png (+0 -0)
➕ mobile/android/app/src/main/res/drawable-xxxhdpi/android12splash.png (+0 -0)

...and 23 more files

📄 Description

This uses flutter_native_splash to generate splash screens with the Immich icon. I reduced the size of the splash screen, as well. There is still an outstanding bug in the Android 12 splash screen, but it is an improvement from before. Replaces #1499 and should close #1443.

This requires some changes to the ios/ folder which is in the .gitignore.
image

I had to manually set the XCode Project to use the LaunchScreen.storyboard:
image

Either we need to add those files to repo, or else you need to make the build scripts run the make create_splash function to generate the splash screens. Or something else, maybe? I think that was all the configuration I had to do, but there may be more at flutter_native_splash.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1520 **Author:** [@martyfuhry](https://github.com/martyfuhry) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/6/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `chore/flutter-native-splash` --- ### 📝 Commits (2) - [`e48911c`](https://github.com/immich-app/immich/commit/e48911c0078471a802fd953e1d955b50ec06baab) rebasing - [`d1942fa`](https://github.com/immich-app/immich/commit/d1942fa2d4d581af8a162261573dc88694705e10) added launch background image to repository ### 📊 Changes **43 files changed** (+373 additions, -156 deletions) <details> <summary>View changed files</summary> ➕ `mobile/android/app/src/main/res/drawable-hdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-hdpi/splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-mdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-mdpi/splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night-hdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night-mdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night-v21/background.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night-v21/launch_background.xml` (+9 -0) ➕ `mobile/android/app/src/main/res/drawable-night-xhdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night-xxhdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night-xxxhdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night/background.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-night/launch_background.xml` (+9 -0) ➕ `mobile/android/app/src/main/res/drawable-v21/background.png` (+0 -0) 📝 `mobile/android/app/src/main/res/drawable-v21/launch_background.xml` (+6 -9) ➕ `mobile/android/app/src/main/res/drawable-xhdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-xhdpi/splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-xxhdpi/android12splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-xxhdpi/splash.png` (+0 -0) ➕ `mobile/android/app/src/main/res/drawable-xxxhdpi/android12splash.png` (+0 -0) _...and 23 more files_ </details> ### 📄 Description This uses `flutter_native_splash` to generate splash screens with the Immich icon. I reduced the size of the splash screen, as well. There is still an outstanding [bug in the Android 12 splash screen](https://github.com/jonbhanson/flutter_native_splash/issues/508), but it is an improvement from before. Replaces #1499 and should close #1443. This requires some changes to the `ios/` folder which is in the `.gitignore`. ![image](https://user-images.githubusercontent.com/100457/216351037-e6e25cbb-926d-46f5-bd32-43cca97bdf0a.png) I had to manually set the XCode Project to use the LaunchScreen.storyboard: ![image](https://user-images.githubusercontent.com/100457/216351173-c46ce36a-47dc-447f-bb2c-f73a242bbf34.png) Either we need to add those files to repo, or else you need to make the build scripts run the `make create_splash` function to generate the splash screens. Or something else, maybe? I think that was all the configuration I had to do, but there may be more at [`flutter_native_splash`](https://pub.dev/packages/flutter_native_splash). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:58:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?