immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1429] [MERGED] build(docker): Use ghcr.io as build cache instead of gha #9063

New Issue
Closed
opened 2026-02-05 13:57:51 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:57:51 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1429
Author: @bo0tzz
Created: 1/26/2023
Status: ✅ Merged
Merged: 1/26/2023
Merged by: @alextran1502

Base: main ← Head: main

📝 Commits (2)

  • 2422b75 build(docker): Use github registry as build cache
  • fed1353 build(docker): Only write to cache if not PR

📊 Changes

1 file changed (+13 additions, -3 deletions)

View changed files

📝 .github/workflows/docker.yml (+13 -3)

📄 Description

This pr replaces the gha-internal layer caching with an image pushed to ghcr.io. This works more reliably than the gha cache (which I'm pretty sure is bugged), with the added benefit that there is no 10GB cache limit. One caveat is that pull requests cannot -write- cache entries, because the push fails with a permission error. This is somewhat odd, because normal images can be pushed no problem, but I can't figure it out and it doesn't seem a big issue anyways :P

I'm not 100% confident about this caching approach (it feels a little gross), so I'd like to hear others' opinions on it before this is merged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1429 **Author:** [@bo0tzz](https://github.com/bo0tzz) **Created:** 1/26/2023 **Status:** ✅ Merged **Merged:** 1/26/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`2422b75`](https://github.com/immich-app/immich/commit/2422b75a958db25c90021bc18e2218e72950b910) build(docker): Use github registry as build cache - [`fed1353`](https://github.com/immich-app/immich/commit/fed1353d5ca7b8b6c37316b0378658940e2eacce) build(docker): Only write to cache if not PR ### 📊 Changes **1 file changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker.yml` (+13 -3) </details> ### 📄 Description This pr replaces the gha-internal layer caching with an image pushed to ghcr.io. This works more reliably than the gha cache (which I'm pretty sure is bugged), with the added benefit that there is no 10GB cache limit. One caveat is that pull requests cannot -write- cache entries, because the push fails with a permission error. This is somewhat odd, because normal images can be pushed no problem, but I can't figure it out and it doesn't seem a big issue anyways :P I'm not 100% confident about this caching approach (it feels a little gross), so I'd like to hear others' opinions on it before this is merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:57:51 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9063
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?