immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1313] [MERGED] chore(web,server): run code coverage reports #8991

New Issue
Closed
opened 2026-02-05 13:56:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:56:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1313
Author: @jrasm91
Created: 1/12/2023
Status: ✅ Merged
Merged: 1/13/2023
Merged by: @alextran1502

Base: main ← Head: chore/code-coverage

📝 Commits (4)

  • 4024d4e chore(web,server): run code coverage reports
  • edfd345 chore(tests): fail test check if coverage drops
  • e1c292f chore: disable e2e until they are fixed
  • d450e95 chore(web): coverage threshold

📊 Changes

6 files changed (+231 additions, -84 deletions)

View changed files

📝 .github/workflows/test.yml (+8 -8)
📝 .gitignore (+1 -0)
📝 server/libs/domain/src/user/user.service.spec.ts (+199 -63)
📝 server/package.json (+13 -1)
📝 web/jest.config.mjs (+8 -11)
📝 web/package.json (+2 -1)

📄 Description

This PR runs code coverage reports by default in the test action.

For the web:

  • The action will fail if the code coverage degrades
  • Current coverage is about 4% overall (lmao)

For the server:

  • The action will fail if the code coverage degrades
  • Current coverage is about 25% overall
  • Current coverage is above 80% for @app/domain
  • Disabled e2e tests, since they are failing. Can re-enable once they're working again. In the meantime we could prevent merge if the test action fails.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1313 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 1/12/2023 **Status:** ✅ Merged **Merged:** 1/13/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `chore/code-coverage` --- ### 📝 Commits (4) - [`4024d4e`](https://github.com/immich-app/immich/commit/4024d4e4f813185b2f42566eb4b3b7fc42397afc) chore(web,server): run code coverage reports - [`edfd345`](https://github.com/immich-app/immich/commit/edfd34530c8e0718bf579d783bbb13c3ce58d66b) chore(tests): fail test check if coverage drops - [`e1c292f`](https://github.com/immich-app/immich/commit/e1c292f46636020f07e91aa566e3ee7438c9a281) chore: disable e2e until they are fixed - [`d450e95`](https://github.com/immich-app/immich/commit/d450e95039831995bbf11f337143184e10fe26d3) chore(web): coverage threshold ### 📊 Changes **6 files changed** (+231 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+8 -8) 📝 `.gitignore` (+1 -0) 📝 `server/libs/domain/src/user/user.service.spec.ts` (+199 -63) 📝 `server/package.json` (+13 -1) 📝 `web/jest.config.mjs` (+8 -11) 📝 `web/package.json` (+2 -1) </details> ### 📄 Description This PR runs code coverage reports by default in the test action. For the web: - The action will fail if the code coverage degrades - Current coverage is about 4% overall (lmao) For the server: - The action will fail if the code coverage degrades - Current coverage is about 25% overall - Current coverage is above 80% for `@app/domain` - Disabled e2e tests, since they are failing. Can re-enable once they're working again. In the meantime we could prevent merge if the test action fails. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:56:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8991
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?