immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1282] [MERGED] fix(nginx): Switch to sh #8974

New Issue
Closed
opened 2026-02-05 13:56:22 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:56:22 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1282
Author: @otbutz
Created: 1/10/2023
Status: ✅ Merged
Merged: 1/10/2023
Merged by: @alextran1502

Base: main ← Head: patch-3

📝 Commits (2)

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 nginx/Dockerfile (+1 -1)
📝 nginx/start.sh (+3 -3)

📄 Description

Sadly theirs still an sh process left after #1210

docker top immich_proxy 
UID                 PID                 PPID                C                   STIME               TTY                 TIME                CMD
systemd+            2274224             2274202             0                   07:18               ?                   00:00:00            /bin/sh -c /start.sh
systemd+            2274272             2274224             0                   07:18               ?                   00:00:00            nginx: master process nginx -g daemon off;
systemd+            2274286             2274272             0                   07:18               ?                   00:00:00            nginx: worker process
systemd+            2274287             2274272             0                   07:18               ?                   00:00:00            nginx: worker process

I think this is caused by the shebang mismatch and sh spawning a bash process for the script.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1282 **Author:** [@otbutz](https://github.com/otbutz) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 1/10/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `patch-3` --- ### 📝 Commits (2) - [`d040f90`](https://github.com/immich-app/immich/commit/d040f90754b70f8731979d20eb6763efa27be0c9) Switch to sh - [`bc5bd4e`](https://github.com/immich-app/immich/commit/bc5bd4e0989df67da6144fb4fc0aa9e4562818e0) Fix entrypoint ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `nginx/Dockerfile` (+1 -1) 📝 `nginx/start.sh` (+3 -3) </details> ### 📄 Description Sadly theirs still an sh process left after #1210 ``` docker top immich_proxy UID PID PPID C STIME TTY TIME CMD systemd+ 2274224 2274202 0 07:18 ? 00:00:00 /bin/sh -c /start.sh systemd+ 2274272 2274224 0 07:18 ? 00:00:00 nginx: master process nginx -g daemon off; systemd+ 2274286 2274272 0 07:18 ? 00:00:00 nginx: worker process systemd+ 2274287 2274272 0 07:18 ? 00:00:00 nginx: worker process ``` I *think* this is caused by the shebang mismatch and `sh` spawning a `bash` process for the script. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:56:22 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8974
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?