immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #1185] [MERGED] refactor(server): drop salt column #8943

New Issue
Closed
opened 2026-02-05 13:55:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:55:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1185
Author: @jrasm91
Created: 12/27/2022
Status: ✅ Merged
Merged: 12/27/2022
Merged by: @jrasm91

Base: main ← Head: refactor/remove-salt-column

📝 Commits (1)

  • 2dccbec refactor(server): drop salt column

📊 Changes

6 files changed (+20 additions, -25 deletions)

View changed files

📝 server/apps/cli/src/commands/reset-admin-password.command.ts (+1 -3)
📝 server/apps/immich/src/api-v1/user/user.core.ts (+5 -15)
📝 server/apps/immich/src/api-v1/user/user.service.spec.ts (+0 -3)
📝 server/apps/immich/src/modules/immich-jwt/immich-jwt.service.spec.ts (+0 -1)
📝 server/libs/database/src/entities/user.entity.ts (+0 -3)
➕ server/libs/database/src/migrations/1672109862870-DropSaltColumn.ts (+14 -0)

📄 Description

The salt column is redundant, since it is stored as part of the hashed password:

https://github.com/kelektiv/node.bcrypt.js#hash-info.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1185 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 12/27/2022 **Status:** ✅ Merged **Merged:** 12/27/2022 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `refactor/remove-salt-column` --- ### 📝 Commits (1) - [`2dccbec`](https://github.com/immich-app/immich/commit/2dccbecb82787df4b8c9dfb9ddda62e6e2745033) refactor(server): drop salt column ### 📊 Changes **6 files changed** (+20 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `server/apps/cli/src/commands/reset-admin-password.command.ts` (+1 -3) 📝 `server/apps/immich/src/api-v1/user/user.core.ts` (+5 -15) 📝 `server/apps/immich/src/api-v1/user/user.service.spec.ts` (+0 -3) 📝 `server/apps/immich/src/modules/immich-jwt/immich-jwt.service.spec.ts` (+0 -1) 📝 `server/libs/database/src/entities/user.entity.ts` (+0 -3) ➕ `server/libs/database/src/migrations/1672109862870-DropSaltColumn.ts` (+14 -0) </details> ### 📄 Description The salt column is redundant, since it is stored as part of the hashed password: https://github.com/kelektiv/node.bcrypt.js#hash-info. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:55:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8943
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?