immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #1071] [MERGED] refactor(server): device info service #8892

New Issue
Closed
opened 2026-02-05 13:54:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:54:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/1071
Author: @jrasm91
Created: 12/8/2022
Status: ✅ Merged
Merged: 12/8/2022
Merged by: @alextran1502

Base: main ← Head: refactor/device-info-service

📝 Commits (3)

  • f26f95e refactor(server): device info service
  • fa3f3ed use upsertDeviceInfo in mobile app
  • 4274dc6 fix: return types and dedupe code

📊 Changes

23 files changed (+468 additions, -443 deletions)

View changed files

📝 mobile/lib/modules/backup/services/backup.service.dart (+2 -2)
📝 mobile/lib/modules/login/providers/authentication.provider.dart (+2 -2)
📝 mobile/openapi/.openapi-generator/FILES (+3 -6)
📝 mobile/openapi/README.md (+2 -2)
📝 mobile/openapi/doc/DeviceInfoApi.md (+60 -8)
➖ mobile/openapi/doc/UpdateDeviceInfoDto.md (+0 -17)
📝 mobile/openapi/doc/UpsertDeviceInfoDto.md (+1 -1)
📝 mobile/openapi/lib/api.dart (+1 -2)
📝 mobile/openapi/lib/api/device_info_api.dart (+79 -14)
📝 mobile/openapi/lib/api_client.dart (+2 -4)
➖ mobile/openapi/lib/model/create_device_info_dto.dart (+0 -136)
📝 mobile/openapi/lib/model/upsert_device_info_dto.dart (+20 -20)
📝 mobile/openapi/test/device_info_api_test.dart (+15 -2)
➖ mobile/openapi/test/update_device_info_dto_test.dart (+0 -37)
📝 mobile/openapi/test/upsert_device_info_dto_test.dart (+3 -3)
📝 server/apps/immich/src/api-v1/device-info/device-info.controller.ts (+22 -12)
➕ server/apps/immich/src/api-v1/device-info/device-info.service.spec.ts (+65 -0)
📝 server/apps/immich/src/api-v1/device-info/device-info.service.ts (+14 -55)
➖ server/apps/immich/src/api-v1/device-info/dto/update-device-info.dto.ts (+0 -15)
📝 server/apps/immich/src/api-v1/device-info/dto/upsert-device-info.dto.ts (+1 -1)

...and 3 more files

📄 Description

Refactor the device info endpoints to be a unified "upsert".

TODO:

  • Update the mobile app to use the new endpoint (help?)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/1071 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 12/8/2022 **Status:** ✅ Merged **Merged:** 12/8/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/device-info-service` --- ### 📝 Commits (3) - [`f26f95e`](https://github.com/immich-app/immich/commit/f26f95e0191b6eaba60f4f9456780eb3416884bb) refactor(server): device info service - [`fa3f3ed`](https://github.com/immich-app/immich/commit/fa3f3ed5605d27131d1e01625dd1481fff67f994) use upsertDeviceInfo in mobile app - [`4274dc6`](https://github.com/immich-app/immich/commit/4274dc60b2e75ee13cd69b574ddc95ef8c853996) fix: return types and dedupe code ### 📊 Changes **23 files changed** (+468 additions, -443 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/backup/services/backup.service.dart` (+2 -2) 📝 `mobile/lib/modules/login/providers/authentication.provider.dart` (+2 -2) 📝 `mobile/openapi/.openapi-generator/FILES` (+3 -6) 📝 `mobile/openapi/README.md` (+2 -2) 📝 `mobile/openapi/doc/DeviceInfoApi.md` (+60 -8) ➖ `mobile/openapi/doc/UpdateDeviceInfoDto.md` (+0 -17) 📝 `mobile/openapi/doc/UpsertDeviceInfoDto.md` (+1 -1) 📝 `mobile/openapi/lib/api.dart` (+1 -2) 📝 `mobile/openapi/lib/api/device_info_api.dart` (+79 -14) 📝 `mobile/openapi/lib/api_client.dart` (+2 -4) ➖ `mobile/openapi/lib/model/create_device_info_dto.dart` (+0 -136) 📝 `mobile/openapi/lib/model/upsert_device_info_dto.dart` (+20 -20) 📝 `mobile/openapi/test/device_info_api_test.dart` (+15 -2) ➖ `mobile/openapi/test/update_device_info_dto_test.dart` (+0 -37) 📝 `mobile/openapi/test/upsert_device_info_dto_test.dart` (+3 -3) 📝 `server/apps/immich/src/api-v1/device-info/device-info.controller.ts` (+22 -12) ➕ `server/apps/immich/src/api-v1/device-info/device-info.service.spec.ts` (+65 -0) 📝 `server/apps/immich/src/api-v1/device-info/device-info.service.ts` (+14 -55) ➖ `server/apps/immich/src/api-v1/device-info/dto/update-device-info.dto.ts` (+0 -15) 📝 `server/apps/immich/src/api-v1/device-info/dto/upsert-device-info.dto.ts` (+1 -1) _...and 3 more files_ </details> ### 📄 Description Refactor the device info endpoints to be a unified "upsert". TODO: - Update the mobile app to use the new endpoint (help?) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:54:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?