immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #911] [MERGED] test(server): all the tests #8816

New Issue
Closed
opened 2026-02-05 13:53:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:53:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/911
Author: @jrasm91
Created: 11/2/2022
Status: ✅ Merged
Merged: 11/4/2022
Merged by: @alextran1502

Base: main ← Head: feature/tests

📝 Commits (5)

📊 Changes

12 files changed (+558 additions, -96 deletions)

View changed files

➕ server/apps/immich/src/api-v1/asset/dto/check-existing-assets.dto.spec.ts (+28 -0)
📝 server/apps/immich/src/api-v1/asset/dto/check-existing-assets.dto.ts (+5 -3)
➕ server/apps/immich/src/api-v1/auth/dto/login-credential.dto.spec.ts (+33 -0)
📝 server/apps/immich/src/api-v1/auth/dto/login-credential.dto.ts (+4 -3)
📝 server/apps/immich/src/api-v1/auth/dto/sign-up.dto.spec.ts (+33 -16)
📝 server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts (+5 -2)
➕ server/apps/immich/src/config/asset-upload.config.spec.ts (+141 -0)
📝 server/apps/immich/src/config/asset-upload.config.ts (+49 -37)
➕ server/apps/immich/src/config/profile-image-upload.config.spec.ts (+114 -0)
📝 server/apps/immich/src/config/profile-image-upload.config.ts (+45 -33)
➕ server/apps/immich/src/modules/immich-jwt/immich-jwt.service.spec.ts (+100 -0)
📝 server/apps/immich/src/modules/immich-jwt/strategies/jwt.strategy.ts (+1 -2)

📄 Description

Not sure how/when you want to merge tests in, I'll just keep adding more here until I hear something. Happy to split them into separate PR's if that is better.

Starting Coverage

image

Current Coverage

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/911 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 11/2/2022 **Status:** ✅ Merged **Merged:** 11/4/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feature/tests` --- ### 📝 Commits (5) - [`fc9988b`](https://github.com/immich-app/immich/commit/fc9988be7d1898f192f537800beccf6f57730fd6) test(server): file upload - [`785d9d5`](https://github.com/immich-app/immich/commit/785d9d5d2144922828134b56a17be12ff1e755eb) test: asset dto - [`61429f7`](https://github.com/immich-app/immich/commit/61429f7f143db9ef32169a190a51adba4f56449a) test: auth dto - [`2fb972b`](https://github.com/immich-app/immich/commit/2fb972b0385cb35263738c4b2622e39f0eeff944) test: jwt service - [`935c9d1`](https://github.com/immich-app/immich/commit/935c9d11aebd4ba49b75611cdb10a6f3ef8d30ce) chore: linting ### 📊 Changes **12 files changed** (+558 additions, -96 deletions) <details> <summary>View changed files</summary> ➕ `server/apps/immich/src/api-v1/asset/dto/check-existing-assets.dto.spec.ts` (+28 -0) 📝 `server/apps/immich/src/api-v1/asset/dto/check-existing-assets.dto.ts` (+5 -3) ➕ `server/apps/immich/src/api-v1/auth/dto/login-credential.dto.spec.ts` (+33 -0) 📝 `server/apps/immich/src/api-v1/auth/dto/login-credential.dto.ts` (+4 -3) 📝 `server/apps/immich/src/api-v1/auth/dto/sign-up.dto.spec.ts` (+33 -16) 📝 `server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts` (+5 -2) ➕ `server/apps/immich/src/config/asset-upload.config.spec.ts` (+141 -0) 📝 `server/apps/immich/src/config/asset-upload.config.ts` (+49 -37) ➕ `server/apps/immich/src/config/profile-image-upload.config.spec.ts` (+114 -0) 📝 `server/apps/immich/src/config/profile-image-upload.config.ts` (+45 -33) ➕ `server/apps/immich/src/modules/immich-jwt/immich-jwt.service.spec.ts` (+100 -0) 📝 `server/apps/immich/src/modules/immich-jwt/strategies/jwt.strategy.ts` (+1 -2) </details> ### 📄 Description Not sure how/when you want to merge tests in, I'll just keep adding more here until I hear something. Happy to split them into separate PR's if that is better. Starting Coverage ![image](https://user-images.githubusercontent.com/4334196/199384293-d48910e6-9adb-44ef-9209-f30ed3c80a4f.png) Current Coverage ![image](https://user-images.githubusercontent.com/4334196/199384418-886d8e0b-9403-4659-a922-c3bc4d61475e.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:53:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?