immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-28 11:20:07 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #831] [CLOSED] [Mobile]: 830: make sure upload re-uses http client #8780

New Issue
Closed
opened 2026-02-05 13:53:09 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:53:09 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/831
Author: @esiqveland
Created: 10/16/2022
Status: ❌ Closed

Base: main ← Head: mobile_upload_reuse_httpclient

📝 Commits (1)

  • 65ad72b 830: make sure upload re-uses http client

📊 Changes

6 files changed (+204 additions, -85 deletions)

View changed files

📝 mobile/lib/modules/backup/background_service/background.service.dart (+7 -4)
📝 mobile/lib/modules/backup/models/current_upload_asset.model.dart (+9 -1)
📝 mobile/lib/modules/backup/models/error_upload_asset.model.dart (+7 -1)
📝 mobile/lib/modules/backup/providers/backup.provider.dart (+5 -3)
📝 mobile/lib/modules/backup/services/backup.service.dart (+67 -76)
➕ mobile/lib/modules/backup/services/uploader.service.dart (+109 -0)

📄 Description

Initial upload on a large timeline is slow. My 8000 photos takes at least 3 hours even when on the same local network.

I noticed that the http client is created new for every single file in the upload. This breaks connection pooling/caching, making each upload setup a new connection.

This also moves the upload process towards centering around the CurrentUploadAsset object.

I created a issue here:
https://github.com/immich-app/immich/issues/830

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/831 **Author:** [@esiqveland](https://github.com/esiqveland) **Created:** 10/16/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `mobile_upload_reuse_httpclient` --- ### 📝 Commits (1) - [`65ad72b`](https://github.com/immich-app/immich/commit/65ad72b248e4311814ff53c80f6663db9ed05615) 830: make sure upload re-uses http client ### 📊 Changes **6 files changed** (+204 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/backup/background_service/background.service.dart` (+7 -4) 📝 `mobile/lib/modules/backup/models/current_upload_asset.model.dart` (+9 -1) 📝 `mobile/lib/modules/backup/models/error_upload_asset.model.dart` (+7 -1) 📝 `mobile/lib/modules/backup/providers/backup.provider.dart` (+5 -3) 📝 `mobile/lib/modules/backup/services/backup.service.dart` (+67 -76) ➕ `mobile/lib/modules/backup/services/uploader.service.dart` (+109 -0) </details> ### 📄 Description Initial upload on a large timeline is slow. My 8000 photos takes at least 3 hours even when on the same local network. I noticed that the http client is created new for every single file in the upload. This breaks connection pooling/caching, making each upload setup a new connection. This also moves the upload process towards centering around the CurrentUploadAsset object. I created a issue here: https://github.com/immich-app/immich/issues/830 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:53:09 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?