immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #837] [MERGED] fix(mobile) back button navigation Android #8779

New Issue
Closed
opened 2026-02-05 13:53:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:53:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/837
Author: @zkhan93
Created: 10/17/2022
Status: ✅ Merged
Merged: 10/19/2022
Merged by: @alextran1502

Base: main ← Head: fix/back-navigation

📝 Commits (1)

📊 Changes

3 files changed (+13 additions, -6 deletions)

View changed files

📝 mobile/lib/modules/login/ui/login_form.dart (+1 -1)
📝 mobile/lib/shared/views/splash_screen.dart (+3 -3)
📝 mobile/lib/shared/views/tab_controller_page.dart (+9 -2)

📄 Description

this PR is to fix a bug reported by issue #310,

additionally there are screens (e.g. Splash Screen) which should not be visited again when back button is pressed,
to handle such cases I have replaced some router.push calls with router.replace calls.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/837 **Author:** [@zkhan93](https://github.com/zkhan93) **Created:** 10/17/2022 **Status:** ✅ Merged **Merged:** 10/19/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/back-navigation` --- ### 📝 Commits (1) - [`a3ca530`](https://github.com/immich-app/immich/commit/a3ca5307a58294ac198377963181c7cdf87eda0c) fixes #310 back button navigation ### 📊 Changes **3 files changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/login/ui/login_form.dart` (+1 -1) 📝 `mobile/lib/shared/views/splash_screen.dart` (+3 -3) 📝 `mobile/lib/shared/views/tab_controller_page.dart` (+9 -2) </details> ### 📄 Description this PR is to fix a bug reported by issue #310, additionally there are screens (e.g. Splash Screen) which should not be visited again when back button is pressed, to handle such cases I have replaced some `router.push` calls with `router.replace` calls. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:53:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?