immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #700] [MERGED] fix(mobile): Fixed iOS 16 overflow cache and memory leaked in gallery viewer. #8729

New Issue
Closed
opened 2026-02-05 13:52:16 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:52:16 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/700
Author: @alextran1502
Created: 9/16/2022
Status: ✅ Merged
Merged: 9/17/2022
Merged by: @alextran1502

Base: main ← Head: dev/fix-image-viewer-error-mobile

📝 Commits (10+)

📊 Changes

12 files changed (+77 additions, -126 deletions)

View changed files

📝 mobile/lib/modules/asset_viewer/ui/remote_photo_view.dart (+7 -24)
📝 mobile/lib/modules/asset_viewer/ui/top_control_app_bar.dart (+1 -3)
📝 mobile/lib/modules/asset_viewer/views/gallery_viewer.dart (+0 -2)
📝 mobile/lib/modules/asset_viewer/views/image_viewer_page.dart (+0 -6)
📝 mobile/lib/modules/backup/models/available_album.model.dart (+1 -1)
📝 mobile/lib/modules/backup/providers/backup.provider.dart (+24 -19)
📝 mobile/lib/modules/backup/ui/album_info_card.dart (+17 -11)
📝 mobile/lib/modules/home/ui/thumbnail_image.dart (+9 -6)
📝 mobile/lib/routing/router.gr.dart (+1 -13)
📝 mobile/openapi/lib/model/asset_response_dto.dart (+2 -4)
📝 mobile/pubspec.lock (+11 -32)
📝 mobile/pubspec.yaml (+4 -5)

📄 Description

This PR fixed the issue of overflow cache on iOS16, and the image viewer leaked memory in the gallery view.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/700 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 9/17/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `dev/fix-image-viewer-error-mobile` --- ### 📝 Commits (10+) - [`0e9bea4`](https://github.com/immich-app/immich/commit/0e9bea4c28ee870b19a6ecbc449a56e05e7e35cd) Refactor - [`0f1dcc4`](https://github.com/immich-app/immich/commit/0f1dcc4b6c0a5f85608b47653f13e4b52d462688) update dependencies - [`5135885`](https://github.com/immich-app/immich/commit/5135885453a2192a235913a2adc51a1dc51d2a4f) Update deprecated method - [`e634b4c`](https://github.com/immich-app/immich/commit/e634b4c1fa5cb1096851850dddadfb5981ec51eb) Remove unused functions - [`2d4962a`](https://github.com/immich-app/immich/commit/2d4962af5c5bd2d6ea68f1b93a50dc3fa64b85f7) Make app bar transparent in image viewer - [`e06187f`](https://github.com/immich-app/immich/commit/e06187feac6ea695b615c18a3bde8465d612a9d9) Remove debug print - [`5d08810`](https://github.com/immich-app/immich/commit/5d0881052b855ffeb58e6304a5a57f9c3650ea9a) properly evict remoteviewerimage provider - [`bcf8593`](https://github.com/immich-app/immich/commit/bcf859346d9f0563a371cd4e38891b1f86b6b216) tracking down error thumbnail bug - [`f6d72db`](https://github.com/immich-app/immich/commit/f6d72db953b3cb9f95a3c229a990948c2c501ad2) Fixed cache overflow - [`dfdf7cc`](https://github.com/immich-app/immich/commit/dfdf7cc809ee785ac985a7b7bcef7ff0452b9f31) Fixed cache overflow ### 📊 Changes **12 files changed** (+77 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/asset_viewer/ui/remote_photo_view.dart` (+7 -24) 📝 `mobile/lib/modules/asset_viewer/ui/top_control_app_bar.dart` (+1 -3) 📝 `mobile/lib/modules/asset_viewer/views/gallery_viewer.dart` (+0 -2) 📝 `mobile/lib/modules/asset_viewer/views/image_viewer_page.dart` (+0 -6) 📝 `mobile/lib/modules/backup/models/available_album.model.dart` (+1 -1) 📝 `mobile/lib/modules/backup/providers/backup.provider.dart` (+24 -19) 📝 `mobile/lib/modules/backup/ui/album_info_card.dart` (+17 -11) 📝 `mobile/lib/modules/home/ui/thumbnail_image.dart` (+9 -6) 📝 `mobile/lib/routing/router.gr.dart` (+1 -13) 📝 `mobile/openapi/lib/model/asset_response_dto.dart` (+2 -4) 📝 `mobile/pubspec.lock` (+11 -32) 📝 `mobile/pubspec.yaml` (+4 -5) </details> ### 📄 Description This PR fixed the issue of overflow cache on iOS16, and the image viewer leaked memory in the gallery view. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:52:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?