immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #633] [MERGED] Add all server checks to CI - fix lint issues #8702

New Issue
Closed
opened 2026-02-05 13:51:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:51:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/633
Author: @jbaez
Created: 9/8/2022
Status: ✅ Merged
Merged: 9/8/2022
Merged by: @jbaez

Base: main ← Head: fix/server-lint-errors

📝 Commits (1)

  • 1f4ba73 Add all server checks to CI - fix lint issues

📊 Changes

19 files changed (+47 additions, -70 deletions)

View changed files

📝 .github/workflows/test.yml (+3 -3)
📝 server/apps/immich/src/api-v1/album/album-repository.ts (+2 -3)
📝 server/apps/immich/src/api-v1/album/album.controller.ts (+0 -1)
📝 server/apps/immich/src/api-v1/album/album.service.spec.ts (+0 -1)
📝 server/apps/immich/src/api-v1/album/dto/update-album.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/asset/asset.controller.ts (+1 -2)
📝 server/apps/immich/src/api-v1/asset/asset.service.spec.ts (+32 -33)
📝 server/apps/immich/src/api-v1/asset/dto/get-asset-thumbnail.dto.ts (+1 -2)
📝 server/apps/immich/src/api-v1/asset/dto/serve-file.dto.ts (+2 -2)
📝 server/apps/immich/src/api-v1/auth/auth.controller.ts (+1 -8)
📝 server/apps/immich/src/api-v1/auth/response-dto/login-response.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/device-info/dto/update-device-info.dto.ts (+0 -2)
📝 server/apps/immich/src/api-v1/server-info/server-info.controller.ts (+1 -4)
📝 server/apps/immich/src/api-v1/user/user.controller.ts (+0 -1)
📝 server/apps/immich/src/app.module.ts (+0 -1)
📝 server/apps/immich/src/main.ts (+0 -1)
📝 server/apps/immich/src/modules/background-task/background-task.service.ts (+0 -1)
📝 server/apps/microservices/src/processors/generate-checksum.processor.ts (+1 -1)
📝 server/apps/microservices/src/processors/metadata-extraction.processor.ts (+1 -2)

📄 Description

CI will now run linter, type-checks and tests for the server.

All the lint issues have been fixed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/633 **Author:** [@jbaez](https://github.com/jbaez) **Created:** 9/8/2022 **Status:** ✅ Merged **Merged:** 9/8/2022 **Merged by:** [@jbaez](https://github.com/jbaez) **Base:** `main` ← **Head:** `fix/server-lint-errors` --- ### 📝 Commits (1) - [`1f4ba73`](https://github.com/immich-app/immich/commit/1f4ba73da72cc4c827a528eda7676f7022a784e9) Add all server checks to CI - fix lint issues ### 📊 Changes **19 files changed** (+47 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+3 -3) 📝 `server/apps/immich/src/api-v1/album/album-repository.ts` (+2 -3) 📝 `server/apps/immich/src/api-v1/album/album.controller.ts` (+0 -1) 📝 `server/apps/immich/src/api-v1/album/album.service.spec.ts` (+0 -1) 📝 `server/apps/immich/src/api-v1/album/dto/update-album.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/asset/asset.controller.ts` (+1 -2) 📝 `server/apps/immich/src/api-v1/asset/asset.service.spec.ts` (+32 -33) 📝 `server/apps/immich/src/api-v1/asset/dto/get-asset-thumbnail.dto.ts` (+1 -2) 📝 `server/apps/immich/src/api-v1/asset/dto/serve-file.dto.ts` (+2 -2) 📝 `server/apps/immich/src/api-v1/auth/auth.controller.ts` (+1 -8) 📝 `server/apps/immich/src/api-v1/auth/response-dto/login-response.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/device-info/dto/update-device-info.dto.ts` (+0 -2) 📝 `server/apps/immich/src/api-v1/server-info/server-info.controller.ts` (+1 -4) 📝 `server/apps/immich/src/api-v1/user/user.controller.ts` (+0 -1) 📝 `server/apps/immich/src/app.module.ts` (+0 -1) 📝 `server/apps/immich/src/main.ts` (+0 -1) 📝 `server/apps/immich/src/modules/background-task/background-task.service.ts` (+0 -1) 📝 `server/apps/microservices/src/processors/generate-checksum.processor.ts` (+1 -1) 📝 `server/apps/microservices/src/processors/metadata-extraction.processor.ts` (+1 -2) </details> ### 📄 Description CI will now run linter, type-checks and tests for the server. All the lint issues have been fixed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:51:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8702
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?