immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #545] [MERGED] fix(server): avoid loading all file content on memory #8660

New Issue
Closed
opened 2026-02-05 13:51:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:51:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/545
Author: @panoti
Created: 8/28/2022
Status: ✅ Merged
Merged: 8/28/2022
Merged by: @alextran1502

Base: main ← Head: fix/undefined-exif

📝 Commits (1)

  • 52a1e36 fix(server): use file path instead buffer to reduce memory usage

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 server/apps/microservices/src/processors/metadata-extraction.processor.ts (+4 -3)

📄 Description

  • fix undefined exif data error from user ibra
  • pass directly file path into exifr.parse function because exifr has file parser with the best performance as they said exifr reads the file from disk, only a few hundred bytes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/545 **Author:** [@panoti](https://github.com/panoti) **Created:** 8/28/2022 **Status:** ✅ Merged **Merged:** 8/28/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/undefined-exif` --- ### 📝 Commits (1) - [`52a1e36`](https://github.com/immich-app/immich/commit/52a1e36a5580f0c5272063440bc6d73ee33d20a0) fix(server): use file path instead buffer to reduce memory usage ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/apps/microservices/src/processors/metadata-extraction.processor.ts` (+4 -3) </details> ### 📄 Description - [x] fix undefined exif data error from user `ibra` - [x] pass directly file path into `exifr.parse` function because `exifr` has file parser with the best performance as they said *exifr reads the file from disk, only a few hundred bytes.* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:51:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8660
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?