immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #522] [MERGED] refactor(server): move constant into common package #8650

New Issue
Closed
opened 2026-02-05 13:50:55 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:50:55 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/522
Author: @panoti
Created: 8/23/2022
Status: ✅ Merged
Merged: 8/23/2022
Merged by: @alextran1502

Base: main ← Head: refactor/env-config

📝 Commits (4)

  • da0dd7b refactor(server): move constant into common package
  • 597851c refactor(server): re-arrange import statement in microservice module
  • cd00422 refactor(server): move app.config into common package
  • 8a63acf fix(server): e2e testing

📊 Changes

18 files changed (+72 additions, -40 deletions)

View changed files

📝 server/apps/immich/src/api-v1/server-info/server-info.service.ts (+1 -1)
📝 server/apps/immich/src/app.module.ts (+1 -1)
📝 server/apps/immich/src/config/asset-upload.config.ts (+1 -1)
📝 server/apps/immich/src/config/profile-image-upload.config.ts (+1 -1)
📝 server/apps/immich/test/jest-e2e.json (+1 -0)
📝 server/apps/microservices/src/microservices.module.ts (+12 -9)
📝 server/apps/microservices/src/processors/asset-uploaded.processor.ts (+3 -3)
📝 server/apps/microservices/src/processors/metadata-extraction.processor.ts (+12 -12)
📝 server/apps/microservices/src/processors/thumbnail.processor.ts (+10 -10)
📝 server/apps/microservices/src/processors/video-transcode.processor.ts (+2 -2)
📝 server/libs/common/src/config/app.config.ts (+0 -0)
➕ server/libs/common/src/config/index.ts (+1 -0)
➕ server/libs/common/src/constants/index.ts (+1 -0)
📝 server/libs/common/src/constants/upload_location.constant.ts (+0 -0)
➕ server/libs/common/src/index.ts (+2 -0)
➕ server/libs/common/tsconfig.lib.json (+9 -0)
📝 server/nest-cli.json (+9 -0)
📝 server/tsconfig.json (+6 -0)

📄 Description

  • move common constants, app.config into common package.
  • add config validation for microservices module.
  • re-arrange import statement in alphabet order (in microservice module first).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/522 **Author:** [@panoti](https://github.com/panoti) **Created:** 8/23/2022 **Status:** ✅ Merged **Merged:** 8/23/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/env-config` --- ### 📝 Commits (4) - [`da0dd7b`](https://github.com/immich-app/immich/commit/da0dd7b29b1399dc2d95e32c84453bc1985d5920) refactor(server): move constant into common package - [`597851c`](https://github.com/immich-app/immich/commit/597851ca5655a620f935c7a3531a8e0abaeff067) refactor(server): re-arrange import statement in microservice module - [`cd00422`](https://github.com/immich-app/immich/commit/cd0042241f23a4d1118c6fb8ab1edd82906dac2f) refactor(server): move app.config into common package - [`8a63acf`](https://github.com/immich-app/immich/commit/8a63acfaace78bc57007ca21633c0bdc37592460) fix(server): e2e testing ### 📊 Changes **18 files changed** (+72 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `server/apps/immich/src/api-v1/server-info/server-info.service.ts` (+1 -1) 📝 `server/apps/immich/src/app.module.ts` (+1 -1) 📝 `server/apps/immich/src/config/asset-upload.config.ts` (+1 -1) 📝 `server/apps/immich/src/config/profile-image-upload.config.ts` (+1 -1) 📝 `server/apps/immich/test/jest-e2e.json` (+1 -0) 📝 `server/apps/microservices/src/microservices.module.ts` (+12 -9) 📝 `server/apps/microservices/src/processors/asset-uploaded.processor.ts` (+3 -3) 📝 `server/apps/microservices/src/processors/metadata-extraction.processor.ts` (+12 -12) 📝 `server/apps/microservices/src/processors/thumbnail.processor.ts` (+10 -10) 📝 `server/apps/microservices/src/processors/video-transcode.processor.ts` (+2 -2) 📝 `server/libs/common/src/config/app.config.ts` (+0 -0) ➕ `server/libs/common/src/config/index.ts` (+1 -0) ➕ `server/libs/common/src/constants/index.ts` (+1 -0) 📝 `server/libs/common/src/constants/upload_location.constant.ts` (+0 -0) ➕ `server/libs/common/src/index.ts` (+2 -0) ➕ `server/libs/common/tsconfig.lib.json` (+9 -0) 📝 `server/nest-cli.json` (+9 -0) 📝 `server/tsconfig.json` (+6 -0) </details> ### 📄 Description - [x] move common constants, `app.config` into `common` package. - [x] add config validation for microservices module. - [x] re-arrange import statement in alphabet order (in microservice module first). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:50:55 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?