immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #439] [MERGED] Fix error in logout procedure and guard for each route #8613

New Issue
Closed
opened 2026-02-05 13:50:16 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:50:16 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/439
Author: @alextran1502
Created: 8/8/2022
Status: ✅ Merged
Merged: 8/8/2022
Merged by: @alextran1502

Base: main ← Head: fix-438-error-in-logout-procedure

📝 Commits (1)

  • c3e4114 Fix error in logout procedure and guard for each route

📊 Changes

9 files changed (+56 additions, -18 deletions)

View changed files

📝 web/src/hooks.ts (+1 -1)
📝 web/src/routes/admin/index.svelte (+9 -1)
📝 web/src/routes/albums/[albumId]/index.svelte (+9 -1)
📝 web/src/routes/albums/[albumId]/photos/[assetId].svelte (+3 -4)
📝 web/src/routes/albums/index.svelte (+9 -1)
📝 web/src/routes/auth/logout.ts (+2 -1)
📝 web/src/routes/photos/[assetId].svelte (+6 -7)
📝 web/src/routes/photos/index.svelte (+8 -1)
📝 web/src/routes/sharing/index.svelte (+9 -1)

📄 Description

Fix #438

  • Fixed serverApi not removing accessToken when logging out
  • Fixed route not checking for session info to redirect

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/439 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 8/8/2022 **Status:** ✅ Merged **Merged:** 8/8/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix-438-error-in-logout-procedure` --- ### 📝 Commits (1) - [`c3e4114`](https://github.com/immich-app/immich/commit/c3e411460197f0d7bc1911c9f3e2f4b2e37e0ca1) Fix error in logout procedure and guard for each route ### 📊 Changes **9 files changed** (+56 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `web/src/hooks.ts` (+1 -1) 📝 `web/src/routes/admin/index.svelte` (+9 -1) 📝 `web/src/routes/albums/[albumId]/index.svelte` (+9 -1) 📝 `web/src/routes/albums/[albumId]/photos/[assetId].svelte` (+3 -4) 📝 `web/src/routes/albums/index.svelte` (+9 -1) 📝 `web/src/routes/auth/logout.ts` (+2 -1) 📝 `web/src/routes/photos/[assetId].svelte` (+6 -7) 📝 `web/src/routes/photos/index.svelte` (+8 -1) 📝 `web/src/routes/sharing/index.svelte` (+9 -1) </details> ### 📄 Description Fix #438 * Fixed `serverApi` not removing `accessToken` when logging out * Fixed route not checking for session info to redirect --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:50:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8613
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?