immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 16 Packages Projects Releases 10 Wiki Activity

[BUG] Docker Secrets are not supported for all sensitive environment variables #859

New Issue
Closed
opened 2026-02-04 23:04:52 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-04 23:04:52 +03:00
Owner
Copy Link

Originally created by @mark-monteiro on GitHub (May 18, 2023).

The bug

Docker secret support (https://github.com/immich-app/immich/issues/14) was partially implemented in https://github.com/immich-app/immich/pull/1254, but only for PostgreSQL environment variables. There are a few other sensitive environment variables that would benefit from docker secret support that were missed in the original implementation:

  • TYPESENSE_API_KEY
  • REDIS_USERNAME
  • REDIS_PASSWORD
  • others?

The OS that Immich Server is running on

Docker (Ubuntu host)

Version of Immich Server

v1.55.1

Version of Immich Mobile App

v1.55.1

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

Originally created by @mark-monteiro on GitHub (May 18, 2023). ### The bug Docker secret support (https://github.com/immich-app/immich/issues/14) was partially implemented in https://github.com/immich-app/immich/pull/1254, but only for PostgreSQL environment variables. There are a few other sensitive environment variables that would benefit from docker secret support that were missed in the original implementation: - TYPESENSE_API_KEY - REDIS_USERNAME - REDIS_PASSWORD - others? ### The OS that Immich Server is running on Docker (Ubuntu host) ### Version of Immich Server v1.55.1 ### Version of Immich Mobile App v1.55.1 ### Platform with the issue - [X] Server - [ ] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash N/A ``` ### Additional information _No response_
OVERLORD commented 2026-02-04 23:05:02 +03:00
Author
Owner
Copy Link

@mark-monteiro commented on GitHub (May 18, 2023):

After a bit more investigation, neither Typesense nor Redis support Docker secrets in the compose file for the environment variables mentioned. Which makes supporting them in Immich a bit useless since they'll need to be exposed as environment variables for the other services anyways. I will close this issue.

@mark-monteiro commented on GitHub (May 18, 2023): After a bit more investigation, neither Typesense nor Redis support Docker secrets in the compose file for the environment variables mentioned. Which makes supporting them in Immich a bit useless since they'll need to be exposed as environment variables for the other services anyways. I will close this issue.
OVERLORD commented 2026-02-04 23:05:08 +03:00
Author
Owner
Copy Link

@abhi-chakrab commented on GitHub (Jul 15, 2023):

@mark-monteiro - Is there a possibility to at least add the REDIS_PASSWORD as a secret. It is possible to use a workaround as per the below suggestion from the official repo:
https://github.com/docker-library/redis/issues/46#issuecomment-335326234

I have also created a PR for the basic script changes - https://github.com/immich-app/immich/pull/3282

@abhi-chakrab commented on GitHub (Jul 15, 2023): @mark-monteiro - Is there a possibility to at least add the REDIS_PASSWORD as a secret. It is possible to use a workaround as per the below suggestion from the official repo: https://github.com/docker-library/redis/issues/46#issuecomment-335326234 I have also created a PR for the basic script changes - https://github.com/immich-app/immich/pull/3282
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?