immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #261] [MERGED] Set TypeScript to strict mode and fix issues related to server types #8532

New Issue
Closed
opened 2026-02-05 13:48:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:48:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/261
Author: @jbaez
Created: 6/25/2022
Status: ✅ Merged
Merged: 6/25/2022
Merged by: @alextran1502

Base: main ← Head: fix/server-types

📝 Commits (7)

  • 03287cb Fix lint issues and some other TS issues
  • 2b1a288 Fix the rest of TS issues
  • 5d4f570 Merge remote-tracking branch 'origin/main' into fix/server-types
  • fb1e056 Move global.d.ts to server src folder
  • faa7bc2 Update AssetReponseDto duration type
  • 79841c6 Set context when logging error in asset.service
  • f324ed2 Fix wrong AppController merge conflict resolution

📊 Changes

64 files changed (+415 additions, -273 deletions)

View changed files

📝 server/apps/immich/src/api-v1/album/album-repository.ts (+5 -6)
📝 server/apps/immich/src/api-v1/album/album.service.spec.ts (+5 -1)
📝 server/apps/immich/src/api-v1/album/album.service.ts (+1 -1)
📝 server/apps/immich/src/api-v1/album/dto/add-assets.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/album/dto/add-users.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/album/dto/create-album.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/album/dto/remove-assets.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/album/dto/update-album.dto.ts (+2 -2)
📝 server/apps/immich/src/api-v1/album/response-dto/album-response.dto.ts (+2 -2)
📝 server/apps/immich/src/api-v1/asset/asset.controller.ts (+12 -9)
📝 server/apps/immich/src/api-v1/asset/asset.service.ts (+49 -13)
📝 server/apps/immich/src/api-v1/asset/dto/create-asset.dto.ts (+8 -8)
📝 server/apps/immich/src/api-v1/asset/dto/create-exif.dto.ts (+15 -15)
📝 server/apps/immich/src/api-v1/asset/dto/delete-asset.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/asset/dto/get-all-asset-query.dto.ts (+2 -2)
📝 server/apps/immich/src/api-v1/asset/dto/get-all-asset-response.dto.ts (+4 -3)
📝 server/apps/immich/src/api-v1/asset/dto/get-asset.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/asset/dto/get-new-asset-query.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/asset/dto/search-asset.dto.ts (+1 -1)
📝 server/apps/immich/src/api-v1/asset/dto/serve-file.dto.ts (+5 -6)

...and 44 more files

📄 Description

Added new npm commands to run lint and check code. We would normally just use npm run check:all which does all the checks.

Fixed all the lint and TypeScript issues, removing unused imports and variables, adding types and interfaces, and updating the code where needed.

The commits in this PR have more info on the changes made

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/261 **Author:** [@jbaez](https://github.com/jbaez) **Created:** 6/25/2022 **Status:** ✅ Merged **Merged:** 6/25/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/server-types` --- ### 📝 Commits (7) - [`03287cb`](https://github.com/immich-app/immich/commit/03287cbc91f42e408438a538e7ed4d2c40013862) Fix lint issues and some other TS issues - [`2b1a288`](https://github.com/immich-app/immich/commit/2b1a288910e0f1f74099789ed110d3d9e79d95d2) Fix the rest of TS issues - [`5d4f570`](https://github.com/immich-app/immich/commit/5d4f570f45f9a1a08c435882393b038767bcfbcd) Merge remote-tracking branch 'origin/main' into fix/server-types - [`fb1e056`](https://github.com/immich-app/immich/commit/fb1e056133b215b107a159a9a3b7b06f0c818c0d) Move global.d.ts to server `src` folder - [`faa7bc2`](https://github.com/immich-app/immich/commit/faa7bc2778fb9dd5cf76c17844cf4bddd4965afd) Update AssetReponseDto duration type - [`79841c6`](https://github.com/immich-app/immich/commit/79841c64eef618b08b61fe058ea97741a5885e3f) Set context when logging error in asset.service - [`f324ed2`](https://github.com/immich-app/immich/commit/f324ed26ce6658577b7024e5dbd3eb0a866ff3ff) Fix wrong AppController merge conflict resolution ### 📊 Changes **64 files changed** (+415 additions, -273 deletions) <details> <summary>View changed files</summary> 📝 `server/apps/immich/src/api-v1/album/album-repository.ts` (+5 -6) 📝 `server/apps/immich/src/api-v1/album/album.service.spec.ts` (+5 -1) 📝 `server/apps/immich/src/api-v1/album/album.service.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/album/dto/add-assets.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/album/dto/add-users.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/album/dto/create-album.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/album/dto/remove-assets.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/album/dto/update-album.dto.ts` (+2 -2) 📝 `server/apps/immich/src/api-v1/album/response-dto/album-response.dto.ts` (+2 -2) 📝 `server/apps/immich/src/api-v1/asset/asset.controller.ts` (+12 -9) 📝 `server/apps/immich/src/api-v1/asset/asset.service.ts` (+49 -13) 📝 `server/apps/immich/src/api-v1/asset/dto/create-asset.dto.ts` (+8 -8) 📝 `server/apps/immich/src/api-v1/asset/dto/create-exif.dto.ts` (+15 -15) 📝 `server/apps/immich/src/api-v1/asset/dto/delete-asset.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/asset/dto/get-all-asset-query.dto.ts` (+2 -2) 📝 `server/apps/immich/src/api-v1/asset/dto/get-all-asset-response.dto.ts` (+4 -3) 📝 `server/apps/immich/src/api-v1/asset/dto/get-asset.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/asset/dto/get-new-asset-query.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/asset/dto/search-asset.dto.ts` (+1 -1) 📝 `server/apps/immich/src/api-v1/asset/dto/serve-file.dto.ts` (+5 -6) _...and 44 more files_ </details> ### 📄 Description Added new npm commands to run lint and check code. We would normally just use `npm run check:all` which does all the checks. Fixed all the lint and TypeScript issues, removing unused imports and variables, adding types and interfaces, and updating the code where needed. The commits in this PR have more info on the changes made --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:48:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?