immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #260] [MERGED] Delete assets from server if local deletion fails #8529

New Issue
Closed
opened 2026-02-05 13:48:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:48:52 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/260
Author: @matthinc
Created: 6/24/2022
Status: ✅ Merged
Merged: 6/24/2022
Merged by: @alextran1502

Base: main ← Head: fix-delete-locally

📝 Commits (2)

  • 20df865 Delete assets from server if local deletion fails
  • 0e8666a Remove commented line

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 mobile/lib/shared/providers/asset.provider.dart (+7 -3)

📄 Description

Just a little edge-case that I stumbled across. If an asset was deleted locally but still exists on the server, the deletion fails beacause deleteWithIds throws an uncaught exception.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/260 **Author:** [@matthinc](https://github.com/matthinc) **Created:** 6/24/2022 **Status:** ✅ Merged **Merged:** 6/24/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix-delete-locally` --- ### 📝 Commits (2) - [`20df865`](https://github.com/immich-app/immich/commit/20df865bc75c6365732112a423412a62f5751da9) Delete assets from server if local deletion fails - [`0e8666a`](https://github.com/immich-app/immich/commit/0e8666ae4ca73b20d906b60bc239323fef2101f4) Remove commented line ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/shared/providers/asset.provider.dart` (+7 -3) </details> ### 📄 Description Just a little edge-case that I stumbled across. If an asset was deleted locally but still exists on the server, the deletion fails beacause `deleteWithIds` throws an uncaught exception. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:48:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8529
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?