immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #211] [MERGED] Input validation for email and server endpoint in mobile app #8515

New Issue
Closed
opened 2026-02-05 13:48:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:48:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/211
Author: @matthinc
Created: 6/10/2022
Status: ✅ Merged
Merged: 6/12/2022
Merged by: @alextran1502

Base: main ← Head: main

📝 Commits (1)

  • 5c3119b Input validation for email and server endpoint in mobile app

📊 Changes

1 file changed (+18 additions, -0 deletions)

View changed files

📝 mobile/lib/modules/login/ui/login_form.dart (+18 -0)

📄 Description

Hi,

I installed Immich on a Samsung phone yesterday and realized that the E-Mail completion of this phone adds trailing whitespaces which is hard to spot and causes the login to fail. So I added an input validator that warns about such malformed emails.

I also added a check whether the server endpoint starts with http:// or https:// as this might not be obvious to less-technical users.

Is there any reason why the server-endpoint field is pre-filled with an url?
I think this is confusing as all other fields just show hints.

final serverEndpointController = useTextEditingController(text: 'http://your-server-ip:2283');

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/211 **Author:** [@matthinc](https://github.com/matthinc) **Created:** 6/10/2022 **Status:** ✅ Merged **Merged:** 6/12/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`5c3119b`](https://github.com/immich-app/immich/commit/5c3119b0648f3b36b758d5d3b382a2b05237ab48) Input validation for email and server endpoint in mobile app ### 📊 Changes **1 file changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/login/ui/login_form.dart` (+18 -0) </details> ### 📄 Description Hi, I installed Immich on a Samsung phone yesterday and realized that the E-Mail completion of this phone adds trailing whitespaces which is hard to spot and causes the login to fail. So I added an input validator that warns about such malformed emails. I also added a check whether the server endpoint starts with http:// or https:// as this might not be obvious to less-technical users. Is there any reason why the server-endpoint field is pre-filled with an url? I think this is confusing as all other fields just show hints. ```dart final serverEndpointController = useTextEditingController(text: 'http://your-server-ip:2283'); ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:48:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8515
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?