immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #194] [MERGED] Fix user e2e tests #8507

New Issue
Closed
opened 2026-02-05 13:48:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:48:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/194
Author: @jbaez
Created: 5/31/2022
Status: ✅ Merged
Merged: 6/6/2022
Merged by: @alextran1502

Base: main ← Head: fix/e2e-tests

📝 Commits (3)

  • 9da69e8 WIP fix user e2e tests
  • cca6293 Fix migrations
  • 1b45182 Merge remote-tracking branch 'origin/main' into fix/e2e-tests

📊 Changes

10 files changed (+114 additions, -76 deletions)

View changed files

📝 Makefile (+1 -1)
📝 docker/.env.test (+8 -2)
📝 docker/docker-compose.test.yml (+1 -3)
📝 server/package.json (+1 -1)
📝 server/src/api-v1/auth/auth.service.ts (+23 -19)
📝 server/src/api-v1/user/dto/create-user.dto.ts (+4 -4)
➕ server/src/api-v1/user/response-dto/user.ts (+19 -0)
📝 server/src/api-v1/user/user.service.ts (+17 -32)
📝 server/src/config/database.config.ts (+3 -1)
📝 server/test/user.e2e-spec.ts (+37 -13)

📄 Description

The e2e tests still don't seem to work due to migrations not running.

Changes:

  • update user.e2e tests to use new userService.createUser method
  • fix server typeorm command to use ORM config
  • update make test-e2e to re-create database volume every time
  • add User DTO
  • update auth.service and user.service to use User DTO
  • update CreateUserDto making optional properties that are optional

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/194 **Author:** [@jbaez](https://github.com/jbaez) **Created:** 5/31/2022 **Status:** ✅ Merged **Merged:** 6/6/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/e2e-tests` --- ### 📝 Commits (3) - [`9da69e8`](https://github.com/immich-app/immich/commit/9da69e868733d4c37525c68fb2595323339f4e74) WIP fix user e2e tests - [`cca6293`](https://github.com/immich-app/immich/commit/cca62937d7568013bbda1d461584bba2dd058298) Fix migrations - [`1b45182`](https://github.com/immich-app/immich/commit/1b4518253a191daec1b8ebaaf4cd803de01d044d) Merge remote-tracking branch 'origin/main' into fix/e2e-tests ### 📊 Changes **10 files changed** (+114 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -1) 📝 `docker/.env.test` (+8 -2) 📝 `docker/docker-compose.test.yml` (+1 -3) 📝 `server/package.json` (+1 -1) 📝 `server/src/api-v1/auth/auth.service.ts` (+23 -19) 📝 `server/src/api-v1/user/dto/create-user.dto.ts` (+4 -4) ➕ `server/src/api-v1/user/response-dto/user.ts` (+19 -0) 📝 `server/src/api-v1/user/user.service.ts` (+17 -32) 📝 `server/src/config/database.config.ts` (+3 -1) 📝 `server/test/user.e2e-spec.ts` (+37 -13) </details> ### 📄 Description The e2e tests still don't seem to work due to migrations not running. Changes: - update user.e2e tests to use new `userService.createUser` method - fix server `typeorm` command to use ORM config - update make test-e2e to re-create database volume every time - add User DTO - update auth.service and user.service to use User DTO - update CreateUserDto making optional properties that are optional --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:48:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?