immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #136] [CLOSED] Select album to backup #8482

New Issue
Closed
opened 2026-02-05 13:47:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:47:58 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/136
Author: @EnricoBilla
Created: 5/1/2022
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (7)

  • 8bba83a Persistent album id and initial ui for backup album selection
  • a9b0181 album selection ui
  • 30ef536 album to backup works
  • 19ab7ac update infos on album change
  • f7c08ac load albums only once
  • 142c213 fix remaining assets count
  • ae270fe cleanup code, fix for iOS

📊 Changes

8 files changed (+222 additions, -49 deletions)

View changed files

📝 mobile/lib/constants/hive_box.dart (+4 -0)
📝 mobile/lib/main.dart (+3 -0)
📝 mobile/lib/modules/home/ui/immich_sliver_appbar.dart (+1 -1)
📝 mobile/lib/shared/models/backup_state.model.dart (+7 -7)
➕ mobile/lib/shared/models/hive_saved_backup_info.model.dart (+11 -0)
➕ mobile/lib/shared/models/hive_saved_backup_info.model.g.dart (+41 -0)
📝 mobile/lib/shared/providers/backup.provider.dart (+90 -30)
📝 mobile/lib/shared/views/backup_controller_page.dart (+65 -11)

📄 Description

Hi!
I've been watching this repo for some time and I find it awesome, I've never been able to contribute since I didn't know anything about Flutter until yesterday.

I really wanted to use this app to backup my photo from the camera, but a feature I really needed was the possibility to pick a folder to backup on Android (see #120 and #89). So I decided to give a try, and here is the result.

The photo_manager library doesn't offer any way to read photos directly from folders, for this reason, to reuse the actual code as much as possible, the user will only be able to pick an album (among which there is "Recent" which is the one currently used).
The album picker is a dropdown menu in the Backup settings page for now, it's very easy to move it somewhere else tho.

I tried to use the pattern that were already implemented as much as possible, but since I've no experience in Flutter I may have made some mistakes or followed some bad practice. I'd like to get some feedback about my code to improve.

I'll leave this a draft for now, since it needs to be tested on iOS as I don't have an iPhone.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/136 **Author:** [@EnricoBilla](https://github.com/EnricoBilla) **Created:** 5/1/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (7) - [`8bba83a`](https://github.com/immich-app/immich/commit/8bba83a71936e48dfd72d86a18c3215ff76eaaa9) Persistent album id and initial ui for backup album selection - [`a9b0181`](https://github.com/immich-app/immich/commit/a9b0181ac5cc36c90dc7073cdf2ef451f6dacf6b) album selection ui - [`30ef536`](https://github.com/immich-app/immich/commit/30ef5368cb56e6d530baddc951904f3df69c9d3a) album to backup works - [`19ab7ac`](https://github.com/immich-app/immich/commit/19ab7ace1a8eb76ef1b73a27fca632fce126ad59) update infos on album change - [`f7c08ac`](https://github.com/immich-app/immich/commit/f7c08ac0d7da5e92aa32f02cc38e1f74fd8f3ab1) load albums only once - [`142c213`](https://github.com/immich-app/immich/commit/142c21327908494312cb25afd5ba3f23029bb7fa) fix remaining assets count - [`ae270fe`](https://github.com/immich-app/immich/commit/ae270fed8dc37cb1c3a5ad4926e14c19b2cf34c7) cleanup code, fix for iOS ### 📊 Changes **8 files changed** (+222 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/constants/hive_box.dart` (+4 -0) 📝 `mobile/lib/main.dart` (+3 -0) 📝 `mobile/lib/modules/home/ui/immich_sliver_appbar.dart` (+1 -1) 📝 `mobile/lib/shared/models/backup_state.model.dart` (+7 -7) ➕ `mobile/lib/shared/models/hive_saved_backup_info.model.dart` (+11 -0) ➕ `mobile/lib/shared/models/hive_saved_backup_info.model.g.dart` (+41 -0) 📝 `mobile/lib/shared/providers/backup.provider.dart` (+90 -30) 📝 `mobile/lib/shared/views/backup_controller_page.dart` (+65 -11) </details> ### 📄 Description Hi! I've been watching this repo for some time and I find it awesome, I've never been able to contribute since I didn't know anything about Flutter until yesterday. I really wanted to use this app to backup my photo from the camera, but a feature I really needed was the possibility to pick a folder to backup on Android (see #120 and #89). So I decided to give a try, and here is the result. The photo_manager library doesn't offer any way to read photos directly from folders, for this reason, to reuse the actual code as much as possible, the user will only be able to pick an album (among which there is "Recent" which is the one currently used). The album picker is a dropdown menu in the Backup settings page for now, it's very easy to move it somewhere else tho. I tried to use the pattern that were already implemented as much as possible, but since I've no experience in Flutter I may have made some mistakes or followed some bad practice. I'd like to get some feedback about my code to improve. I'll leave this a draft for now, since it needs to be tested on iOS as I don't have an iPhone. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:47:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?