immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #104] [MERGED] Optimization/fix slow backup when asset list is long. #8464

New Issue
Closed
opened 2026-02-05 13:47:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:47:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/104
Author: @alextran1502
Created: 4/3/2022
Status: ✅ Merged
Merged: 4/3/2022
Merged by: @alextran1502

Base: main ← Head: optimization/fix-backup-slow-on-long-list

📝 Commits (3)

  • 5393df8 Handle pause/restart listening to event on_upload_success and reload asset list after navigating back from BackupControllerPage
  • 57c0320 Remove unsued api endpoint
  • 5a8f895 Fixed slowness problem

📊 Changes

7 files changed (+35 additions, -66 deletions)

View changed files

📝 mobile/ios/fastlane/Fastfile (+3 -3)
📝 mobile/lib/modules/home/ui/immich_sliver_appbar.dart (+6 -2)
📝 mobile/lib/modules/home/views/home_page.dart (+7 -1)
📝 mobile/lib/shared/providers/websocket.provider.dart (+14 -0)
📝 mobile/lib/shared/views/backup_controller_page.dart (+3 -0)
📝 server/src/api-v1/asset/asset.controller.ts (+2 -12)
📝 server/src/api-v1/asset/asset.service.ts (+0 -48)

📄 Description

This PR removed the WebSocket listener on_upload_success to avoid updating the main asset list on the main page.

The app will listen to the event after navigating back from the backup page.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/104 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 4/3/2022 **Status:** ✅ Merged **Merged:** 4/3/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `optimization/fix-backup-slow-on-long-list` --- ### 📝 Commits (3) - [`5393df8`](https://github.com/immich-app/immich/commit/5393df813ff1db2df30fd0a1d1a720e7567f31b1) Handle pause/restart listening to event on_upload_success and reload asset list after navigating back from BackupControllerPage - [`57c0320`](https://github.com/immich-app/immich/commit/57c0320e634f8369fbf34412f4eea17f507c9ca9) Remove unsued api endpoint - [`5a8f895`](https://github.com/immich-app/immich/commit/5a8f895bfa18b87b3bbe60d6eab1195039d8e489) Fixed slowness problem ### 📊 Changes **7 files changed** (+35 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `mobile/ios/fastlane/Fastfile` (+3 -3) 📝 `mobile/lib/modules/home/ui/immich_sliver_appbar.dart` (+6 -2) 📝 `mobile/lib/modules/home/views/home_page.dart` (+7 -1) 📝 `mobile/lib/shared/providers/websocket.provider.dart` (+14 -0) 📝 `mobile/lib/shared/views/backup_controller_page.dart` (+3 -0) 📝 `server/src/api-v1/asset/asset.controller.ts` (+2 -12) 📝 `server/src/api-v1/asset/asset.service.ts` (+0 -48) </details> ### 📄 Description This PR removed the WebSocket listener `on_upload_success` to avoid updating the main asset list on the main page. The app will listen to the event after navigating back from the backup page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:47:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?