[PR #68] [MERGED] Get thumbnail from app #8455

Closed
opened 2026-02-05 13:47:28 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/68
Author: @alextran1502
Created: 3/21/2022
Status: Merged
Merged: 3/22/2022
Merged by: @alextran1502

Base: mainHead: experimental/get-thumbnail-from-app


📝 Commits (10+)

📊 Changes

29 files changed (+480 additions, -244 deletions)

View changed files

.DS_Store (+0 -0)
.gitignore (+1 -0)
PR_CHECKLIST.md (+13 -0)
📝 README.md (+3 -2)
📝 docker/docker-compose.gpu.yml (+1 -1)
📝 docker/docker-compose.yml (+1 -1)
📝 mobile/ios/Podfile.lock (+6 -0)
📝 mobile/ios/fastlane/Fastfile (+3 -0)
📝 mobile/lib/main.dart (+6 -0)
📝 mobile/lib/modules/home/ui/immich_sliver_appbar.dart (+44 -6)
📝 mobile/lib/modules/home/ui/profile_drawer.dart (+68 -7)
📝 mobile/lib/modules/home/views/home_page.dart (+2 -0)
📝 mobile/lib/routing/tab_navigation_observer.dart (+3 -0)
mobile/lib/shared/models/server_info_state.model.dart (+78 -0)
mobile/lib/shared/models/server_version.model.dart (+72 -0)
📝 mobile/lib/shared/providers/server_info.provider.dart (+61 -47)
📝 mobile/lib/shared/services/backup.service.dart (+42 -12)
📝 mobile/lib/shared/services/server_info.service.dart (+7 -0)
📝 mobile/pubspec.yaml (+1 -1)
📝 server/Dockerfile (+2 -2)

...and 9 more files

📄 Description

Fixing issues with Sharp dependency in #65

This PR introduces breaking changes in the way of uploading assets and handling thumbnail images.

The field name of the multipart form was changed from files to assetData. An additional field name of thumbnailData has been added to get the thumbnail byte directly from the mobile app.

The version of the server, iOS, and Android app now start with 1.x.x to accommodate version checking in the mobile app.

This is still not a beta release.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/68 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 3/21/2022 **Status:** ✅ Merged **Merged:** 3/22/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `experimental/get-thumbnail-from-app` --- ### 📝 Commits (10+) - [`a1bc1eb`](https://github.com/immich-app/immich/commit/a1bc1eb0f1a7e01cfcc435dc49e2a27f021346dc) first - [`7e0825b`](https://github.com/immich-app/immich/commit/7e0825bf13a0e509561331266437e4fed76d0796) Download and Store thumbnail from device - [`49a865a`](https://github.com/immich-app/immich/commit/49a865a12e4109dd187860ef736a1235edf79b86) Download and Store thumbnail from device - [`e1de3f4`](https://github.com/immich-app/immich/commit/e1de3f4080f893373e794c3074d1a5ac55e57059) remove dead code - [`252c562`](https://github.com/immich-app/immich/commit/252c5627637bdb7fecd93dfcbf1b249424f0dd72) Change version to 0 instead of 1 - [`6789536`](https://github.com/immich-app/immich/commit/67895361990d98efc5f880a25fd4bb72f6d2418a) Added provider to get server info - [`8d2da93`](https://github.com/immich-app/immich/commit/8d2da9346b18a6b8c0641795739043a7ec7c6834) Added version checking on app - [`fb59786`](https://github.com/immich-app/immich/commit/fb59786ff5d006fc54bd950a52395f0b0cdf5a88) Fixed Typo and Style - [`03a673d`](https://github.com/immich-app/immich/commit/03a673d9a8741a835ed418aacd454551a97999eb) Update Readme - [`19c3887`](https://github.com/immich-app/immich/commit/19c3887d60c58815f4a7b1c18afac2f5d7363a79) Update Readme ### 📊 Changes **29 files changed** (+480 additions, -244 deletions) <details> <summary>View changed files</summary> ➖ `.DS_Store` (+0 -0) ➕ `.gitignore` (+1 -0) ➕ `PR_CHECKLIST.md` (+13 -0) 📝 `README.md` (+3 -2) 📝 `docker/docker-compose.gpu.yml` (+1 -1) 📝 `docker/docker-compose.yml` (+1 -1) 📝 `mobile/ios/Podfile.lock` (+6 -0) 📝 `mobile/ios/fastlane/Fastfile` (+3 -0) 📝 `mobile/lib/main.dart` (+6 -0) 📝 `mobile/lib/modules/home/ui/immich_sliver_appbar.dart` (+44 -6) 📝 `mobile/lib/modules/home/ui/profile_drawer.dart` (+68 -7) 📝 `mobile/lib/modules/home/views/home_page.dart` (+2 -0) 📝 `mobile/lib/routing/tab_navigation_observer.dart` (+3 -0) ➕ `mobile/lib/shared/models/server_info_state.model.dart` (+78 -0) ➕ `mobile/lib/shared/models/server_version.model.dart` (+72 -0) 📝 `mobile/lib/shared/providers/server_info.provider.dart` (+61 -47) 📝 `mobile/lib/shared/services/backup.service.dart` (+42 -12) 📝 `mobile/lib/shared/services/server_info.service.dart` (+7 -0) 📝 `mobile/pubspec.yaml` (+1 -1) 📝 `server/Dockerfile` (+2 -2) _...and 9 more files_ </details> ### 📄 Description Fixing issues with Sharp dependency in #65 This PR introduces breaking changes in the way of uploading assets and handling thumbnail images. The field name of the multipart form was changed from `files` to `assetData`. An additional field name of `thumbnailData` has been added to get the thumbnail byte directly from the mobile app. The version of the server, iOS, and Android app now start with 1.x.x to accommodate version checking in the mobile app. This is still not a beta release. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:47:28 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8455