immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #22] [MERGED] Implemented delete asset on device and on database #8435

New Issue
Closed
opened 2026-02-05 13:47:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 13:47:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/22
Author: @alextran1502
Created: 2/14/2022
Status: ✅ Merged
Merged: 2/14/2022
Merged by: @alextran1502

Base: main ← Head: dev/delete-assets

📝 Commits (10+)

  • 30d07fd refactor serving file function asset service
  • efeab77 added delete assets endpoint
  • 2b8423d Merge branch 'main' of github.com:alextran1502/immich into dev/delete-assets
  • a1519e6 Remove PhotoViewer for now since it create problem in 2.10
  • 660e51a Added error message for wrong decode file and logo for failed to load file
  • 7501b94 Added error message for wrong decode file and logo for failed to load file
  • a9f3be6 added placeholder for delete image
  • 8783af8 Fixed error when read stream cannot be created and crash server
  • 1f18310 Fixed error when read stream cannot be created and crash server
  • 7f477ad Added method to get all asset as raw array

📊 Changes

22 files changed (+511 additions, -10610 deletions)

View changed files

📝 README.md (+3 -4)
📝 mobile/lib/modules/asset_viewer/views/image_viewer_page.dart (+31 -7)
➕ mobile/lib/modules/home/models/delete_asset_response.model.dart (+52 -0)
📝 mobile/lib/modules/home/models/get_all_asset_response.model.dart (+0 -0)
📝 mobile/lib/modules/home/providers/asset.provider.dart (+43 -70)
📝 mobile/lib/modules/home/services/asset.service.dart (+37 -3)
📝 mobile/lib/modules/home/ui/delete_diaglog.dart (+13 -3)
📝 mobile/lib/modules/home/ui/immich_sliver_appbar.dart (+0 -1)
📝 mobile/lib/modules/home/ui/profile_drawer.dart (+2 -0)
📝 mobile/lib/modules/home/ui/thumbnail_image.dart (+16 -3)
📝 mobile/lib/modules/home/views/home_page.dart (+20 -46)
📝 mobile/lib/modules/login/ui/login_form.dart (+28 -26)
📝 mobile/lib/shared/providers/backup.provider.dart (+35 -28)
📝 mobile/lib/shared/services/backup.service.dart (+2 -2)
📝 mobile/lib/shared/services/network.service.dart (+18 -0)
📝 mobile/lib/shared/views/backup_controller_page.dart (+2 -0)
📝 server/package-lock.json (+19 -10336)
📝 server/src/api-v1/asset/asset.controller.ts (+30 -78)
📝 server/src/api-v1/asset/asset.service.ts (+123 -2)
➕ server/src/api-v1/asset/dto/delete-asset.dto.ts (+6 -0)

...and 2 more files

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/22 **Author:** [@alextran1502](https://github.com/alextran1502) **Created:** 2/14/2022 **Status:** ✅ Merged **Merged:** 2/14/2022 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `dev/delete-assets` --- ### 📝 Commits (10+) - [`30d07fd`](https://github.com/immich-app/immich/commit/30d07fd475ce9c1141c52175ef737c19738047c7) refactor serving file function asset service - [`efeab77`](https://github.com/immich-app/immich/commit/efeab77a4e24c4c366ccb620047cd8f5b8ff984c) added delete assets endpoint - [`2b8423d`](https://github.com/immich-app/immich/commit/2b8423df96ba43607156e6dcf30e316e7332027c) Merge branch 'main' of github.com:alextran1502/immich into dev/delete-assets - [`a1519e6`](https://github.com/immich-app/immich/commit/a1519e680f53a8b8966ccbd1e8d0499e6b0ff0a9) Remove PhotoViewer for now since it create problem in 2.10 - [`660e51a`](https://github.com/immich-app/immich/commit/660e51a8a33bee5b76702bdbcebffccd6c160964) Added error message for wrong decode file and logo for failed to load file - [`7501b94`](https://github.com/immich-app/immich/commit/7501b942e8646535a6a1d466bb59af165144f46a) Added error message for wrong decode file and logo for failed to load file - [`a9f3be6`](https://github.com/immich-app/immich/commit/a9f3be680a167161f09430b7498c8dc2cd6c80a7) added placeholder for delete image - [`8783af8`](https://github.com/immich-app/immich/commit/8783af8fd04a3598a3b97de71d938b36f7f87034) Fixed error when read stream cannot be created and crash server - [`1f18310`](https://github.com/immich-app/immich/commit/1f1831087b6c17484e2b1ae29c981c2be5e46054) Fixed error when read stream cannot be created and crash server - [`7f477ad`](https://github.com/immich-app/immich/commit/7f477ad6d3c4b604e3ca64862020003cc21b83f7) Added method to get all asset as raw array ### 📊 Changes **22 files changed** (+511 additions, -10610 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -4) 📝 `mobile/lib/modules/asset_viewer/views/image_viewer_page.dart` (+31 -7) ➕ `mobile/lib/modules/home/models/delete_asset_response.model.dart` (+52 -0) 📝 `mobile/lib/modules/home/models/get_all_asset_response.model.dart` (+0 -0) 📝 `mobile/lib/modules/home/providers/asset.provider.dart` (+43 -70) 📝 `mobile/lib/modules/home/services/asset.service.dart` (+37 -3) 📝 `mobile/lib/modules/home/ui/delete_diaglog.dart` (+13 -3) 📝 `mobile/lib/modules/home/ui/immich_sliver_appbar.dart` (+0 -1) 📝 `mobile/lib/modules/home/ui/profile_drawer.dart` (+2 -0) 📝 `mobile/lib/modules/home/ui/thumbnail_image.dart` (+16 -3) 📝 `mobile/lib/modules/home/views/home_page.dart` (+20 -46) 📝 `mobile/lib/modules/login/ui/login_form.dart` (+28 -26) 📝 `mobile/lib/shared/providers/backup.provider.dart` (+35 -28) 📝 `mobile/lib/shared/services/backup.service.dart` (+2 -2) 📝 `mobile/lib/shared/services/network.service.dart` (+18 -0) 📝 `mobile/lib/shared/views/backup_controller_page.dart` (+2 -0) 📝 `server/package-lock.json` (+19 -10336) 📝 `server/src/api-v1/asset/asset.controller.ts` (+30 -78) 📝 `server/src/api-v1/asset/asset.service.ts` (+123 -2) ➕ `server/src/api-v1/asset/dto/delete-asset.dto.ts` (+6 -0) _...and 2 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 13:47:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8435
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?