immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

Email footer: missing alt attribute on Google Play badge image #8067

New Issue
Closed
opened 2026-02-05 13:30:34 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 13:30:34 +03:00
Owner
Copy Link

Originally created by @divulgacheur on GitHub (Dec 17, 2025).

Mail-Tester reports that one image in Immich invitation emails is missing an alt attribute:

f0b069adb9/server/src/emails/components/footer.template.tsx (L10)

This affects accessibility (screen readers / images blocked) and reduces the Mail-Tester score (e.g., 9.5/10 instead of 10/10).

Expected behavior

All tags in outgoing emails include an alt attribute (even if empty when appropriate).

Actual behavior

The Google Play badge image renders without alt.

Proposed fix

Add an alt prop to the Google Play badge . Since the image is wrapped by a link, a descriptive alt is appropriate.

Suggested:

Google Play badge: alt="Get it on Google Play"

iOS badge: change from alt="Immich" to alt="Download on the App Store"

Acceptance criteria

Rendered email HTML includes alt="..." for both store badge images.

Mail-Tester no longer flags “missing alt attribute” for these images.

Originally created by @divulgacheur on GitHub (Dec 17, 2025). Mail-Tester reports that one image in Immich invitation emails is missing an alt attribute: https://github.com/immich-app/immich/blob/f0b069adb917ee6f5961259d5627167a8228b65f/server/src/emails/components/footer.template.tsx#L10 This affects accessibility (screen readers / images blocked) and reduces the Mail-Tester score (e.g., 9.5/10 instead of 10/10). ### Expected behavior All <img> tags in outgoing emails include an alt attribute (even if empty when appropriate). ### Actual behavior The Google Play badge image renders without alt. ### Proposed fix Add an alt prop to the Google Play badge <Img />. Since the image is wrapped by a link, a descriptive alt is appropriate. #### Suggested: Google Play badge: alt="Get it on Google Play" iOS badge: change from alt="Immich" to alt="Download on the App Store" ### Acceptance criteria Rendered email HTML includes alt="..." for both store badge images. Mail-Tester no longer flags “missing alt attribute” for these images.
OVERLORD commented 2026-02-05 13:30:37 +03:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Dec 17, 2025):

This issue has automatically been closed as it is likely a duplicate. We get a lot of duplicate threads each day, which is why we ask you in the template to confirm that you searched for duplicates before opening one. If you're sure this is not a duplicate, please leave a comment and we will reopen the thread if necessary.

@github-actions[bot] commented on GitHub (Dec 17, 2025): This issue has automatically been closed as it is likely a duplicate. We get a lot of duplicate threads each day, which is why we ask you in the template to confirm that you searched for duplicates before opening one. If you're sure this is not a duplicate, please leave a comment and we will reopen the thread if necessary.
OVERLORD commented 2026-02-05 13:30:38 +03:00
Author
Owner
Copy Link

@divulgacheur commented on GitHub (Dec 17, 2025):

I didn't see a duplicate issue.

@divulgacheur commented on GitHub (Dec 17, 2025): I didn't see a duplicate issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#8067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?