immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 12 Packages Projects Releases 10 Wiki Activity

[BUG] Show Admin name in server stats #710

New Issue
Closed
opened 2026-02-04 22:05:38 +03:00 by OVERLORD · 6 comments
OVERLORD commented 2026-02-04 22:05:38 +03:00
Owner
Copy Link

Originally created by @jrasm91 on GitHub (Feb 24, 2023).

The bug

The admin user's name should be displayed in the usage table (instead of the hard coded "Admin").

image

Platform with the issue

  • Server
  • Web
  • Mobile
Originally created by @jrasm91 on GitHub (Feb 24, 2023). ### The bug The admin user's name should be displayed in the usage table (instead of the hard coded "Admin"). ![image](https://user-images.githubusercontent.com/4334196/221232012-493ef030-f79e-459b-9413-b6cb4969cd9b.png) ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile
OVERLORD commented 2026-02-04 22:05:44 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Feb 24, 2023):

Turning isAll to true resolves the issue. Is there any particular reason to have set it to false ?

3ea107be5a/web/src/routes/admin/server-status/%2Bpage.server.ts (L14)

@martabal commented on GitHub (Feb 24, 2023): Turning `isAll` to true resolves the issue. Is there any particular reason to have set it to false ? https://github.com/immich-app/immich/blob/3ea107be5a726db1b4db43847ad7c33fa8146644/web/src/routes/admin/server-status/%2Bpage.server.ts#L14
OVERLORD commented 2026-02-04 22:05:46 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Feb 25, 2023):

That won't show soft deleted users, which I assume it currently shows now. The isAll flag is misleading because it's really "get users to show on the admin page", which is actually "get all users including deleted users, but exclude me". We should probably not exclude the user ever IMO and the flag should control the withDeleted property.

image

@jrasm91 commented on GitHub (Feb 25, 2023): That won't show soft deleted users, which I assume it currently shows now. The `isAll` flag is misleading because it's really "get users to show on the admin page", which is actually "get all users including deleted users, but exclude me". We should probably not exclude the user ever IMO and the flag should control the `withDeleted` property. ![image](https://user-images.githubusercontent.com/4334196/221296844-5ec9918e-d22e-4b13-9e33-ed75623388cc.png)
OVERLORD commented 2026-02-04 22:05:52 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Feb 25, 2023):

Wouldn't it better to have a new withDeleted query parameter for getAllUsers ?

@martabal commented on GitHub (Feb 25, 2023): Wouldn't it better to have a new `withDeleted` query parameter for getAllUsers ?
OVERLORD commented 2026-02-04 22:05:57 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Feb 25, 2023):

That'd be fine, but then there is no need for isAll.

@jrasm91 commented on GitHub (Feb 25, 2023): That'd be fine, but then there is no need for isAll.
OVERLORD commented 2026-02-04 22:06:00 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Feb 25, 2023):

I think, we still need isAll : when you share an album, to have the list of users you want to share with, isAll allows you to get the list without you inside.

71d8567f18/web/src/lib/components/album-page/user-selection-modal.svelte (L20)

I managed to fix the issue, I can make a PR if you want to review.

@martabal commented on GitHub (Feb 25, 2023): I think, we still need isAll : when you share an album, to have the list of users you want to share with, isAll allows you to get the list without you inside. https://github.com/immich-app/immich/blob/71d8567f186aaab5d58748b5e0ebad8dc852a3e4/web/src/lib/components/album-page/user-selection-modal.svelte#L20 I managed to fix the issue, I can make a PR if you want to review.
OVERLORD commented 2026-02-04 22:06:03 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Feb 25, 2023):

We could add a new one just for deleted.

My personal opinion is that using a query param to exclude your id is not very restful and that should be changed.

@jrasm91 commented on GitHub (Feb 25, 2023): We could add a new one just for deleted. My personal opinion is that using a query param to exclude your id is not very restful and that should be changed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#710
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?