immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[BUG] Images not added to shared album from guest upload #562

New Issue
Closed
opened 2026-02-04 21:21:49 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-04 21:21:49 +03:00
Owner
Copy Link

Originally created by @klejejs on GitHub (Jan 10, 2023).

Describe the bug
I tried uploading some photos as guest from mobile, they were uploaded the first time, but not added to the album. If I try to upload them again, nothing happens and they are still not added to the album.

Task List

Please complete the task list below. We need this information to help us reproduce the bug or point out problems in your setup. You are not providing enough info may delay our effort to help you.

  • I have read thoroughly the README setup and installation instructions.
  • I have included my docker-compose file.
  • I have included my redacted .env file.
  • I have included information on my machine, and environment.

To Reproduce
Steps to reproduce the behavior:

  1. Upload images to the Immich instance
  2. Try unloading them again as a guest to a shared album

Expected behavior
Images are added to shared albums.

System

  • Phone OS: Android 11
  • Server Version: v1.41.0
Originally created by @klejejs on GitHub (Jan 10, 2023). <!-- Note: Please search to see if an issue already exists for the bug you encountered. --> **Describe the bug** I tried uploading some photos as guest from mobile, they were uploaded the first time, but not added to the album. If I try to upload them again, nothing happens and they are still not added to the album. **Task List** *Please complete the task list below. We need this information to help us reproduce the bug or point out problems in your setup. You are not providing enough info may delay our effort to help you.* - [x] I have read thoroughly the README setup and installation instructions. - [ ] I have included my `docker-compose` file. - [ ] I have included my redacted `.env` file. - [ ] I have included information on my machine, and environment. **To Reproduce** Steps to reproduce the behavior: 1. Upload images to the Immich instance 2. Try unloading them again as a guest to a shared album **Expected behavior** Images are added to shared albums. **System** - Phone OS: `Android 11` - Server Version: `v1.41.0`
OVERLORD commented 2026-02-04 21:21:57 +03:00
Author
Owner
Copy Link

@bo0tzz commented on GitHub (Jan 10, 2023):

Looks like there is some code to handle the case of an asset already existing and still add it to the album (https://github.com/immich-app/immich/blob/main/web/src/lib/utils/file-uploader.ts#L132-L140), but it doesn't pass the sharedKey. The addAssetsToAlbum key call after successful upload does: https://github.com/immich-app/immich/blob/main/web/src/lib/utils/file-uploader.ts#L162.

@bo0tzz commented on GitHub (Jan 10, 2023): Looks like there is some code to handle the case of an asset already existing and still add it to the album (https://github.com/immich-app/immich/blob/main/web/src/lib/utils/file-uploader.ts#L132-L140), but it doesn't pass the `sharedKey`. The `addAssetsToAlbum` key call after successful upload does: https://github.com/immich-app/immich/blob/main/web/src/lib/utils/file-uploader.ts#L162.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#562
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?