immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

Star rating for unowned asset is read-only but appears writable #4086

New Issue
Closed
opened 2026-02-05 09:43:02 +03:00 by OVERLORD · 3 comments
OVERLORD commented 2026-02-05 09:43:02 +03:00
Owner
Copy Link

Originally created by @C-Otto on GitHub (Aug 15, 2024).

The bug

If I share an album owned by user A with user B, user B is able to see the star rating for those assets. However, user B seems also be able to SET the star rating (the stars change when moving the mouse over them) - but setting the rating does not work.

Either user B should be able to set the rating, or the UI should indicate that this is a read-only property.

The OS that Immich Server is running on

Debian Stable

Version of Immich Server

v1.112.0

Platform with the issue

  • Server
  • Web
  • Mobile

Reproduction steps

  1. Create album with user A
  2. Share album with user B
  3. As user B, set star rating for one of the assets in the album
Originally created by @C-Otto on GitHub (Aug 15, 2024). ### The bug If I share an album owned by user A with user B, user B is able to see the star rating for those assets. However, user B seems also be able to SET the star rating (the stars change when moving the mouse over them) - but setting the rating does not work. Either user B should be able to set the rating, or the UI should indicate that this is a read-only property. ### The OS that Immich Server is running on Debian Stable ### Version of Immich Server v1.112.0 ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Reproduction steps 1. Create album with user A 2. Share album with user B 3. As user B, set star rating for one of the assets in the album
OVERLORD added the 🖥️web label 2026-02-05 09:43:02 +03:00
OVERLORD commented 2026-02-05 09:43:06 +03:00
Author
Owner
Copy Link

@C-Otto commented on GitHub (Aug 15, 2024):

Similarly, I see the option to identify people (I see the list of detected-but-not-named persons) for assets that are part of the "share all" feature. I don't see this for shared assets in (my own) albums. When I try to edit a person, though, I get a permission error.

@C-Otto commented on GitHub (Aug 15, 2024): Similarly, I see the option to identify people (I see the list of detected-but-not-named persons) for assets that are part of the "share all" feature. I don't see this for shared assets in (my own) albums. When I try to edit a person, though, I get a permission error.
OVERLORD commented 2026-02-05 09:43:08 +03:00
Author
Owner
Copy Link

@stumpigit commented on GitHub (Aug 15, 2024):

Thank you. I could reproduce that. The Star Rating component is actually called correct as read-only. So no request is sent when clicking on the stars. But we have not switched off the hover effect in the component when it is read-only. We still need to adjust this, thanks for the tip.

@stumpigit commented on GitHub (Aug 15, 2024): Thank you. I could reproduce that. The Star Rating component is actually called correct as read-only. So no request is sent when clicking on the stars. But we have not switched off the hover effect in the component when it is read-only. We still need to adjust this, thanks for the tip.
OVERLORD commented 2026-02-05 09:43:12 +03:00
Author
Owner
Copy Link

@flammermann commented on GitHub (Aug 23, 2024):

A similar issue occurs if you are using an external library from a volume mounted as read only. The star rating seems to be available but there is an error in the immich_server container that the xmp file could not be created/written.

Since we are on the topic:

  1. Is there any plan on allowing star ratings for read only external libraries?
  2. It would probably also be a nice feature to allow people I shared an asset with to provide a star rating, which is then shown to me (as the owner of the asset) in the UI in addition to my own rating. (Or maybe even show all people that have access to an asset all ratings from all other people.)
@flammermann commented on GitHub (Aug 23, 2024): A similar issue occurs if you are using an external library from a volume mounted as read only. The star rating seems to be available but there is an error in the immich_server container that the xmp file could not be created/written. Since we are on the topic: 1. Is there any plan on allowing star ratings for read only external libraries? 2. It would probably also be a nice feature to allow people I shared an asset with to provide a star rating, which is then shown to me (as the owner of the asset) in the UI in addition to my own rating. (Or maybe even show all people that have access to an asset all ratings from all other people.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label 🖥️web
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#4086
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?