immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

Add a warning or error message to Server Settings -> External domain #3988

New Issue
Closed
opened 2026-02-05 09:34:28 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 09:34:28 +03:00
Owner
Copy Link

Originally created by @martyfuhry on GitHub (Jul 31, 2024).

The bug

You can enter non-valid URLs to the External domain text box

image

We should get an error message, because this is obviously not a valid entry. In particular, we could try URL.canParse() validate the text.

I would also like to not be required to enter the http:// or https:// prefix, and just have the application conditionally look that up for me. But maybe that would be best as a follow-up issue.

The OS that Immich Server is running on

NA

Version of Immich Server

1.111

Version of Immich Mobile App

NA

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

NA

Your .env content

NA

Reproduction steps

Go to Server Settings -> External domain

Relevant log output

No response

Additional information

No response

Originally created by @martyfuhry on GitHub (Jul 31, 2024). ### The bug You can enter non-valid URLs to the External domain text box ![image](https://github.com/user-attachments/assets/112d988d-a356-4ee5-ad2b-0cbeb47fbd0e) We should get an error message, because this is obviously not a valid entry. In particular, we could try `URL.canParse()` validate the text. I would also like to not be *required* to enter the `http://` or `https://` prefix, and just have the application conditionally look that up for me. But maybe that would be best as a follow-up issue. ### The OS that Immich Server is running on NA ### Version of Immich Server 1.111 ### Version of Immich Mobile App NA ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML NA ``` ### Your .env content ```Shell NA ``` ### Reproduction steps ```bash Go to Server Settings -> External domain ``` ### Relevant log output _No response_ ### Additional information _No response_
OVERLORD added the 🗄️servergood first issue labels 2026-02-05 09:34:28 +03:00
OVERLORD commented 2026-02-05 09:34:33 +03:00
Author
Owner
Copy Link

@bo0tzz commented on GitHub (Jul 31, 2024):

Should just need @IsUrl tacked on at https://github.com/immich-app/immich/blob/main/server/src/dtos/system-config.dto.ts#L380.

@bo0tzz commented on GitHub (Jul 31, 2024): Should just need `@IsUrl` tacked on at https://github.com/immich-app/immich/blob/main/server/src/dtos/system-config.dto.ts#L380.
OVERLORD commented 2026-02-05 09:34:35 +03:00
Author
Owner
Copy Link

@Ghosty01 commented on GitHub (Jul 1, 2025):

when url contains "_" makes trouble :/

@Ghosty01 commented on GitHub (Jul 1, 2025): when url contains "_" makes trouble :/
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label good first issue 🗄️server
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#3988
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?