immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

Web: black bezels in video viewer #3605

New Issue
Closed
opened 2026-02-05 09:05:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 09:05:56 +03:00
Owner
Copy Link

Originally created by @pyorot on GitHub (Jun 21, 2024).

The bug

A change was made in #8757 to close #6191, with a Google-derived like/comment UI control overlapping HTML video player volume/settings/fullscreen controls. Unfortunately, the change simply added a bottom bezel and so shrank the video player, which has made the UI inconsistent with photos, most notably when clicking to play a Live Photo (which then shrinks).

style="height: calc(100% - 64px)" [see original]

image

The discussion mentions several better ways of handling the problem, most notably shifting the Google controls up on videos, which would be inconsistent with their position on photos, but not annoyingly so. The bezeling change is justified by "This would have different effects on different screen sizes, but most of the time it would be an improvement.", which I think is a dubious claim. The Google controls don't even show up on my client and I don't want or know how to make them do so.

Google Photos itself doesn't even bother lol (which is still preferable to the bezels imo).

image

The OS that Immich Server is running on

Debian 12

Version of Immich Server

v1.106.3

Version of Immich Mobile App

n/a

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

-

Your .env content

-

Reproduction steps

Always happens on web video player.

Relevant log output

No response

Additional information

No response

Originally created by @pyorot on GitHub (Jun 21, 2024). ### The bug A change was made in #8757 to close #6191, with a Google-derived like/comment UI control overlapping HTML video player volume/settings/fullscreen controls. Unfortunately, the change simply added a bottom bezel and so shrank the video player, which has made the UI inconsistent with photos, most notably when clicking to play a Live Photo (which then shrinks). > style="height: calc(100% - 64px)" \[see [original](https://github.com/immich-app/immich/blob/42f3b50422a4f3793480b25989b57956a57c222f/web/src/lib/components/asset-viewer/video-native-viewer.svelte#L57)\] ![image](https://github.com/immich-app/immich/assets/28405293/685ef89c-6aeb-407b-9f62-7782b1a0d679) The [discussion](https://github.com/immich-app/immich/issues/6191#issuecomment-2052647784) mentions several better ways of handling the problem, most notably shifting the Google controls up on videos, which would be inconsistent with their position on photos, but not annoyingly so. The bezeling change is justified by "This would have different effects on different screen sizes, but most of the time it would be an improvement.", which I think is a dubious claim. The Google controls don't even show up on my client and I don't want or know how to make them do so. Google Photos itself doesn't even bother lol (which is still preferable to the bezels imo). ![image](https://github.com/immich-app/immich/assets/28405293/7a5d91f2-78a5-4461-acbe-d9a00dfb9ab9) ### The OS that Immich Server is running on Debian 12 ### Version of Immich Server v1.106.3 ### Version of Immich Mobile App n/a ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML - ``` ### Your .env content ```Shell - ``` ### Reproduction steps ```bash Always happens on web video player. ``` ### Relevant log output _No response_ ### Additional information _No response_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#3605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?