immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 14 Packages Projects Releases 10 Wiki Activity

[BUG] Thumbnail file path is constructed incorrectly #344

New Issue
Closed
opened 2026-02-04 19:53:31 +03:00 by OVERLORD · 4 comments
OVERLORD commented 2026-02-04 19:53:31 +03:00
Owner
Copy Link

Originally created by @bo0tzz on GitHub (Oct 4, 2022).

Originally assigned to: @deepesh16b on GitHub.

At https://github.com/immich-app/immich/blob/main/server/apps/microservices/src/processors/thumbnail.processor.ts#L65, the path for a thumbnail file is constructed as follows:
const jpegThumbnailPath = resizePath + originalFilename + '.jpeg';
This has two issues: there is no / between the folder path and the filename, and it is joining paths using string concatenation. Instead, this path should be constructed using the join function like is done a few lines above: https://github.com/immich-app/immich/blob/main/server/apps/microservices/src/processors/thumbnail.processor.ts#L57.

Originally created by @bo0tzz on GitHub (Oct 4, 2022). Originally assigned to: @deepesh16b on GitHub. At https://github.com/immich-app/immich/blob/main/server/apps/microservices/src/processors/thumbnail.processor.ts#L65, the path for a thumbnail file is constructed as follows: `const jpegThumbnailPath = resizePath + originalFilename + '.jpeg';` This has two issues: there is no `/` between the folder path and the filename, and it is joining paths using string concatenation. Instead, this path should be constructed using the `join` function like is done a few lines above: https://github.com/immich-app/immich/blob/main/server/apps/microservices/src/processors/thumbnail.processor.ts#L57.
OVERLORD added the good first issue label 2026-02-04 19:53:31 +03:00
OVERLORD commented 2026-02-04 19:53:43 +03:00
Author
Owner
Copy Link

@deepesh16b commented on GitHub (Oct 4, 2022):

Please assign this to me
@bo0tzz

@deepesh16b commented on GitHub (Oct 4, 2022): Please assign this to me @bo0tzz
OVERLORD commented 2026-02-04 19:53:53 +03:00
Author
Owner
Copy Link

@EdkoPitonak commented on GitHub (Oct 4, 2022):

Hi i would love to work on this if it is possible

@EdkoPitonak commented on GitHub (Oct 4, 2022): Hi i would love to work on this if it is possible
OVERLORD commented 2026-02-04 19:54:02 +03:00
Author
Owner
Copy Link

@zackpollard commented on GitHub (Oct 4, 2022):

Please assign this to me @bo0tzz

You have been assigned, thanks for the interest in working on this! 😄

@zackpollard commented on GitHub (Oct 4, 2022): > Please assign this to me @bo0tzz You have been assigned, thanks for the interest in working on this! 😄
OVERLORD commented 2026-02-04 19:54:19 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Oct 4, 2022):

Resolved in #780

@alextran1502 commented on GitHub (Oct 4, 2022): Resolved in #780
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?