immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

Web: Exiting slideshow with escape key closes the asset viewer #3386

New Issue
Closed
opened 2026-02-05 08:14:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 08:14:43 +03:00
Owner
Copy Link

Originally created by @Snowknight26 on GitHub (May 31, 2024).

The bug

Instead of just exiting the slideshow, pressing Escape while a slideshow is running also closes the asset viewer.

This differs from the behavior of the X ("Exit Slideshow") button in the top left of the slideshow bar, which only exits the slideshow.

The OS that Immich Server is running on

Windows 10 22H2 (19045.4291)

Version of Immich Server

v1.105.1

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Navigate to Photos
2. Click a photo
3. Click the triple dots in the top right
4. Click Slideshow
5. Press Escape to exit fullscreen mode
6. Press Escape to exit the slideshow

Relevant log output

No response

Additional information

I imagine there's some logic missing in the SlideshowBar that handles the escape event. Instead of the AssetViewer component handling escape, the SlideshowBar should?

Originally created by @Snowknight26 on GitHub (May 31, 2024). ### The bug Instead of _just_ exiting the slideshow, pressing Escape while a slideshow is running also closes the asset viewer. This differs from the behavior of the X ("Exit Slideshow") button in the top left of the slideshow bar, which _only_ exits the slideshow. ### The OS that Immich Server is running on Windows 10 22H2 (19045.4291) ### Version of Immich Server v1.105.1 ### Version of Immich Mobile App N/A ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash 1. Navigate to Photos 2. Click a photo 3. Click the triple dots in the top right 4. Click Slideshow 5. Press Escape to exit fullscreen mode 6. Press Escape to exit the slideshow ``` ### Relevant log output _No response_ ### Additional information I imagine there's some logic missing in the SlideshowBar that handles the `escape` event. Instead of the AssetViewer component handling escape, the SlideshowBar should?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#3386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?