immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[BUG] local-reverse-geocoder creates data in node_modules #338

New Issue
Closed
opened 2026-02-04 19:48:46 +03:00 by OVERLORD · 3 comments
OVERLORD commented 2026-02-04 19:48:46 +03:00
Owner
Copy Link

Originally created by @nebulade on GitHub (Sep 28, 2022).

The newly added dependency local-reverse-geocoder tries to create a folder to stash some data within node_modules/ at server/node_modules/local-reverse-geocoder/geonames_dump. This causes problems if node_modules is in read-only filesystem if treated like code (in this case for the Cloudron app package).

I am not sure if this should be reported rather with the upstream module to change https://github.com/tomayac/local-reverse-geocoder/blob/main/index.js#L99 to use the process cwd instead of the code file path, or if immich should provide a better folder path at https://github.com/tomayac/local-reverse-geocoder/blob/main/index.js#L618

I am happy to produce a pull request if the change should be made in immich, otherwise will try to get this into the module itself.

Originally created by @nebulade on GitHub (Sep 28, 2022). The newly added dependency `local-reverse-geocoder` tries to create a folder to stash some data within `node_modules/` at `server/node_modules/local-reverse-geocoder/geonames_dump`. This causes problems if `node_modules` is in read-only filesystem if treated like code (in this case for the Cloudron app package). I am not sure if this should be reported rather with the upstream module to change https://github.com/tomayac/local-reverse-geocoder/blob/main/index.js#L99 to use the process cwd instead of the code file path, or if immich should provide a better folder path at https://github.com/tomayac/local-reverse-geocoder/blob/main/index.js#L618 I am happy to produce a pull request if the change should be made in immich, otherwise will try to get this into the module itself.
OVERLORD commented 2026-02-04 19:49:04 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Sep 28, 2022):

I am open to see the change in Immich since it will probably be faster and easier to control. Let me know if you have any question.

@alextran1502 commented on GitHub (Sep 28, 2022): I am open to see the change in Immich since it will probably be faster and easier to control. Let me know if you have any question.
OVERLORD commented 2026-02-04 19:49:18 +03:00
Author
Owner
Copy Link

@zackpollard commented on GitHub (Sep 28, 2022):

I'm happy for us to put this change in immich, we did consider it but didn't think the default path would cause a problem. Feel free to make a PR that corrects this with a sensible path for storing the data.

@zackpollard commented on GitHub (Sep 28, 2022): I'm happy for us to put this change in immich, we did consider it but didn't think the default path would cause a problem. Feel free to make a PR that corrects this with a sensible path for storing the data.
OVERLORD commented 2026-02-04 19:49:24 +03:00
Author
Owner
Copy Link

@nebulade commented on GitHub (Sep 28, 2022):

The change seems unnecessarily small given that I don't know the codebase conventions, so maybe this works for you? :)

@nebulade commented on GitHub (Sep 28, 2022): The change seems unnecessarily small given that I don't know the codebase conventions, so maybe this works for you? :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?