immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[Feature]: Allow specifying the endpoints using env variables. #318

New Issue
Closed
opened 2026-02-04 19:36:50 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2026-02-04 19:36:50 +03:00
Owner
Copy Link

Originally created by @blmhemu on GitHub (Sep 20, 2022).

Feature detail

For example, at 953d18e795/web/src/api/api.ts (L44)

The server is hard-coded assuming that the runtime is docker-compose and this url / dns works. Ideally, the app should be independent of this. We should rather use env variables and / or process.env to pass this (similar to how we do for postgres / redis). The same goes for proxy as well.
See
7a807f7216/nginx/nginx.conf (L90)
7a807f7216/nginx/nginx.conf (L65)

More instances where this needs to be fixed:
ccf792f9d3/server/apps/microservices/src/processors/metadata-extraction.processor.ts (L194)
ccf792f9d3/server/apps/microservices/src/processors/metadata-extraction.processor.ts (L214)

Platform

Web, Nginx (proxy)

Originally created by @blmhemu on GitHub (Sep 20, 2022). ### Feature detail For example, at https://github.com/immich-app/immich/blob/953d18e795ea2dca27621da5b86bc17d3bb0ab7e/web/src/api/api.ts#L44 The server is hard-coded assuming that the runtime is docker-compose and this url / dns works. Ideally, the app should be independent of this. We should rather use env variables and / or `process.env` to pass this (similar to how we do for postgres / redis). The same goes for proxy as well. See https://github.com/immich-app/immich/blob/7a807f72164a6fbe8a058dacb29e127e509ee065/nginx/nginx.conf#L90 https://github.com/immich-app/immich/blob/7a807f72164a6fbe8a058dacb29e127e509ee065/nginx/nginx.conf#L65 More instances where this needs to be fixed: https://github.com/immich-app/immich/blob/ccf792f9d315821cc12bc08d5f5e41e6f32e4e4f/server/apps/microservices/src/processors/metadata-extraction.processor.ts#L194 https://github.com/immich-app/immich/blob/ccf792f9d315821cc12bc08d5f5e41e6f32e4e4f/server/apps/microservices/src/processors/metadata-extraction.processor.ts#L214 ### Platform Web, Nginx (proxy)
OVERLORD commented 2026-02-04 19:37:04 +03:00
Author
Owner
Copy Link

@bo0tzz commented on GitHub (Oct 31, 2022):

Duplicate of #647

@bo0tzz commented on GitHub (Oct 31, 2022): Duplicate of #647
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?