immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 26 Packages Projects Releases 10 Wiki Activity

Merging person order is the opposite of expected #2690

New Issue
Closed
opened 2026-02-05 06:45:28 +03:00 by OVERLORD · 5 comments
OVERLORD commented 2026-02-05 06:45:28 +03:00
Owner
Copy Link

Originally created by @mmomjian on GitHub (Mar 28, 2024).

The bug

When selecting to Merge a person, Immich defaults to use the currently selected person as the "master" (profile picture and name). I suggest that this is the opposite of expected behavior. When a user selects to "Merge" a person, I suggest they typically have a known (named) target for the Merge. It would make more sense that the default behavior is to Merge a person into an existing person, as opposed to the current behavior.

The OS that Immich Server is running on

Debian 12

Version of Immich Server

1.100.0

Version of Immich Mobile App

1.100.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. View a person
2. Click Merge Person
3. the default behavior is to merge the pictures from someone else into this person

Additional information

No response

Originally created by @mmomjian on GitHub (Mar 28, 2024). ### The bug When selecting to Merge a person, Immich defaults to use the currently selected person as the "master" (profile picture and name). I suggest that this is the opposite of expected behavior. When a user selects to "Merge" a person, I suggest they typically have a known (named) target for the Merge. It would make more sense that the default behavior is to Merge a person *into* an existing person, as opposed to the current behavior. ### The OS that Immich Server is running on Debian 12 ### Version of Immich Server 1.100.0 ### Version of Immich Mobile App 1.100.0 ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash 1. View a person 2. Click Merge Person 3. the default behavior is to merge the pictures from someone else into this person ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 06:45:31 +03:00
Author
Owner
Copy Link

@almulder commented on GitHub (Mar 29, 2024):

On mine I can select 1 person and then another and select what way to merge. The arrows between them. Pressing it swaps locations of who mergers into who. (I just notice that option)

@almulder commented on GitHub (Mar 29, 2024): On mine I can select 1 person and then another and select what way to merge. The arrows between them. Pressing it swaps locations of who mergers into who. (I just notice that option)
OVERLORD commented 2026-02-05 06:45:35 +03:00
Author
Owner
Copy Link

@pyorot commented on GitHub (Jun 22, 2024):

generalises #6382

a bit of a pain to fix tho because selecting people to merge can stack multiple people on the source side of the merge operation, which is more efficient but unintuitive enough to where nobody will think to do it

@pyorot commented on GitHub (Jun 22, 2024): generalises #6382 a bit of a pain to fix tho because selecting people to merge can stack multiple people on the source side of the merge operation, which is more efficient but unintuitive enough to where nobody will think to do it
OVERLORD commented 2026-02-05 06:45:42 +03:00
Author
Owner
Copy Link

@C-Otto commented on GitHub (Aug 13, 2024):

To work around this issue, you can edit the name of the "merge source" (victim) to the name of the "merge destination" (winner), prompting a dialog that you then need to confirm. This works like a charm (and I didn't even know about the "Merge people" options in the "..." menus).

@C-Otto commented on GitHub (Aug 13, 2024): To work around this issue, you can edit the name of the "merge source" (victim) to the name of the "merge destination" (winner), prompting a dialog that you then need to confirm. This works like a charm (and I didn't even know about the "Merge people" options in the "..." menus).
OVERLORD commented 2026-02-05 06:45:50 +03:00
Author
Owner
Copy Link

@C-Otto commented on GitHub (Aug 13, 2024):

I don't see how merging multiple people (named or not) into one is a common use case. I think a common scenario is to merge a "new" person into its already existing (and likely named) variant.

If we only allow merging two people (one into the other), we could easily switch the default order in the "merge people" dialog. This would also fix #6382.

@C-Otto commented on GitHub (Aug 13, 2024): I don't see how merging **multiple** people (named or not) into one is a common use case. I think a common scenario is to merge a "new" person into its already existing (and likely named) variant. If we only allow merging two people (one into the other), we could easily switch the default order in the "merge people" dialog. This would also fix #6382.
OVERLORD commented 2026-02-05 06:45:54 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Sep 12, 2024):

There seem to be two common use cases:

  1. Select a named person, go to the merge page, scroll down and select all duplicates
  2. Scroll through the people page, find a duplicate, go to the merge page, selected a named person

#12601 solves this by:

  • Keeping (1) as the default flow, which implies the original selection is the surviving person in the merge.
  • Automatically swapping when (2) is detected (selected person has no name and first merge candidate has a name)

This still makes it possible to merge multiple people, even in case (2) as additional people can still be added later as additional merge sources.

@jrasm91 commented on GitHub (Sep 12, 2024): There seem to be two common use cases: 1. Select a named person, go to the merge page, scroll down and select all duplicates 2. Scroll through the people page, find a duplicate, go to the merge page, selected a named person #12601 solves this by: - Keeping (1) as the default flow, which implies the original selection is the surviving person in the merge. - Automatically swapping when (2) is detected (selected person has no name and first merge candidate has a name) This still makes it possible to merge multiple people, even in case (2) as additional people can still be added later as additional merge sources.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#2690
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?