immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #25917] fix: improve asset editor exit handling #18399

New Issue
Open
opened 2026-02-05 16:37:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:37:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25917
Author: @michelheusschen
Created: 2/5/2026
Status: 🔄 Open

Base: main ← Head: fix/web-improve-editor-exit

📝 Commits (1)

  • f7f865d fix: improve asset editor exit handling

📊 Changes

5 files changed (+54 additions, -4 deletions)

View changed files

➕ web/src/lib/__mocks__/resize-observer.mock.ts (+8 -0)
📝 web/src/lib/components/asset-viewer/asset-viewer-nav-bar.spec.ts (+2 -4)
📝 web/src/lib/components/asset-viewer/asset-viewer.svelte (+1 -0)
➕ web/src/lib/components/asset-viewer/editor/transform-tool/crop-area.spec.ts (+39 -0)
📝 web/src/lib/managers/edit/transform-manager.svelte.ts (+4 -0)

📄 Description

  • cursor no longer stays in resize mode after hovering the crop area and hitting Escape
  • using the browser back button in the editor no longer reopens the editor on later assets

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25917 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 2/5/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/web-improve-editor-exit` --- ### 📝 Commits (1) - [`f7f865d`](https://github.com/immich-app/immich/commit/f7f865df5041b736b8c669316814de22017819e2) fix: improve asset editor exit handling ### 📊 Changes **5 files changed** (+54 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `web/src/lib/__mocks__/resize-observer.mock.ts` (+8 -0) 📝 `web/src/lib/components/asset-viewer/asset-viewer-nav-bar.spec.ts` (+2 -4) 📝 `web/src/lib/components/asset-viewer/asset-viewer.svelte` (+1 -0) ➕ `web/src/lib/components/asset-viewer/editor/transform-tool/crop-area.spec.ts` (+39 -0) 📝 `web/src/lib/managers/edit/transform-manager.svelte.ts` (+4 -0) </details> ### 📄 Description - cursor no longer stays in resize mode after hovering the crop area and hitting `Escape` - using the browser back button in the editor no longer reopens the editor on later assets --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:37:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18399
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?