immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25891] [MERGED] fix: null validation #18384

New Issue
Closed
opened 2026-02-05 16:37:25 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:37:25 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25891
Author: @jrasm91
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @jrasm91

Base: main ← Head: fix/null-validation

📝 Commits (1)

📊 Changes

18 files changed (+357 additions, -47 deletions)

View changed files

📝 mobile/openapi/lib/model/asset_bulk_update_dto.dart (+1 -1)
📝 mobile/openapi/lib/model/user_admin_create_dto.dart (+13 -1)
📝 open-api/immich-openapi-specs.json (+9 -1)
📝 open-api/typescript-sdk/src/fetch-client.ts (+3 -1)
📝 server/src/controllers/asset.controller.spec.ts (+28 -0)
➕ server/src/controllers/notification-admin.controller.spec.ts (+36 -0)
📝 server/src/controllers/notification.controller.spec.ts (+31 -1)
📝 server/src/controllers/person.controller.spec.ts (+5 -0)
➕ server/src/controllers/shared-link.controller.spec.ts (+34 -0)
➕ server/src/controllers/tag.controller.spec.ts (+73 -0)
📝 server/src/controllers/user-admin.controller.spec.ts (+55 -0)
📝 server/src/controllers/user.controller.spec.ts (+8 -0)
📝 server/src/dtos/asset.dto.ts (+1 -2)
📝 server/src/dtos/notification.dto.ts (+10 -11)
📝 server/src/dtos/shared-link.dto.ts (+1 -1)
📝 server/src/dtos/tag.dto.ts (+2 -2)
📝 server/src/dtos/user.dto.ts (+26 -4)
📝 server/src/validation.ts (+21 -22)

📄 Description

Fix some validation issues that were introduced in #25185, including not being able to reset a user's PIN code.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25891 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/null-validation` --- ### 📝 Commits (1) - [`595dabb`](https://github.com/immich-app/immich/commit/595dabb5dc32df861ec0dd651247eeeb65949ec2) fix: null validation ### 📊 Changes **18 files changed** (+357 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `mobile/openapi/lib/model/asset_bulk_update_dto.dart` (+1 -1) 📝 `mobile/openapi/lib/model/user_admin_create_dto.dart` (+13 -1) 📝 `open-api/immich-openapi-specs.json` (+9 -1) 📝 `open-api/typescript-sdk/src/fetch-client.ts` (+3 -1) 📝 `server/src/controllers/asset.controller.spec.ts` (+28 -0) ➕ `server/src/controllers/notification-admin.controller.spec.ts` (+36 -0) 📝 `server/src/controllers/notification.controller.spec.ts` (+31 -1) 📝 `server/src/controllers/person.controller.spec.ts` (+5 -0) ➕ `server/src/controllers/shared-link.controller.spec.ts` (+34 -0) ➕ `server/src/controllers/tag.controller.spec.ts` (+73 -0) 📝 `server/src/controllers/user-admin.controller.spec.ts` (+55 -0) 📝 `server/src/controllers/user.controller.spec.ts` (+8 -0) 📝 `server/src/dtos/asset.dto.ts` (+1 -2) 📝 `server/src/dtos/notification.dto.ts` (+10 -11) 📝 `server/src/dtos/shared-link.dto.ts` (+1 -1) 📝 `server/src/dtos/tag.dto.ts` (+2 -2) 📝 `server/src/dtos/user.dto.ts` (+26 -4) 📝 `server/src/validation.ts` (+21 -22) </details> ### 📄 Description Fix some validation issues that were introduced in #25185, including not being able to reset a user's PIN code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:37:25 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18384
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?