immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #25874] [MERGED] fix(server): deleting stacked assets #18374

New Issue
Closed
opened 2026-02-05 16:37:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:37:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25874
Author: @jrasm91
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/4/2026
Merged by: @jrasm91

Base: main ← Head: fix/25841

📝 Commits (2)

  • 9fb9988 fix(server): deleting stacked assets
  • 97717cf fix: log a warning when removing an empty directory fails

📊 Changes

6 files changed (+127 additions, -80 deletions)

View changed files

📝 server/src/queries/asset.job.repository.sql (+21 -35)
📝 server/src/repositories/asset-job.repository.ts (+21 -16)
📝 server/src/repositories/storage.repository.ts (+8 -2)
📝 server/src/services/asset.service.spec.ts (+12 -23)
📝 server/src/services/asset.service.ts (+4 -3)
📝 server/test/medium/specs/services/asset.service.spec.ts (+61 -1)

📄 Description

Fixes #25841

Correctly fetch stack information, including primaryStackId, regardless of whether the stack contains archived or deleted assets.

Fixes a flaky e2e test because fs.rm would sometimes throw ENOTEMPTY errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25874 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/25841` --- ### 📝 Commits (2) - [`9fb9988`](https://github.com/immich-app/immich/commit/9fb9988d60b5ea4557d4449cfb056ca25aec431a) fix(server): deleting stacked assets - [`97717cf`](https://github.com/immich-app/immich/commit/97717cf9b5e075d83f515b5692ae385d619b582c) fix: log a warning when removing an empty directory fails ### 📊 Changes **6 files changed** (+127 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `server/src/queries/asset.job.repository.sql` (+21 -35) 📝 `server/src/repositories/asset-job.repository.ts` (+21 -16) 📝 `server/src/repositories/storage.repository.ts` (+8 -2) 📝 `server/src/services/asset.service.spec.ts` (+12 -23) 📝 `server/src/services/asset.service.ts` (+4 -3) 📝 `server/test/medium/specs/services/asset.service.spec.ts` (+61 -1) </details> ### 📄 Description Fixes #25841 Correctly fetch stack information, including `primaryStackId`, regardless of whether the stack contains archived or deleted assets. Fixes a flaky e2e test because `fs.rm` would sometimes throw ENOTEMPTY errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:37:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18374
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?