immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 08:41:28 +03:00
Code Issues 26 Packages Projects Releases 10 Wiki Activity

CLI retry failed request and don't cancel entire flow on error #1835

New Issue
Closed
opened 2026-02-05 04:07:35 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 04:07:35 +03:00
Owner
Copy Link

Originally created by @zackpollard on GitHub (Dec 19, 2023).

Originally assigned to: @etnoy on GitHub.

Currently the CLI will error and cancel the whole process if one request fails. We should probably instead retry a couple of times and then log an error that the asset failed, but continue on to other assets.

Originally created by @zackpollard on GitHub (Dec 19, 2023). Originally assigned to: @etnoy on GitHub. Currently the CLI will error and cancel the whole process if one request fails. We should probably instead retry a couple of times and then log an error that the asset failed, but continue on to other assets.
OVERLORD added the cli label 2026-02-05 04:07:35 +03:00
OVERLORD commented 2026-02-05 04:07:44 +03:00
Author
Owner
Copy Link

@masterT commented on GitHub (Jun 15, 2024):

This is particularly annoying when uploading a lot of assets. Was there any progress toward this issue?

@masterT commented on GitHub (Jun 15, 2024): This is particularly annoying when uploading a lot of assets. Was there any progress toward this issue?
OVERLORD commented 2026-02-05 04:07:49 +03:00
Author
Owner
Copy Link

@masterT commented on GitHub (Jun 18, 2024):

A significant improvement could be using an in-memory queue system (e.g., fastq) and having the ability to retry not just failed asset uploads but also other parts of the CLI.

I'm trying to upload an extensive library, and I have all kinds of network errors (I'm hosted with PikaPod, and my instance sometimes restarts, which makes the whole process crash).

I think I will craft a draft for this and open a PR.

@masterT commented on GitHub (Jun 18, 2024): A significant improvement could be using an in-memory queue system (e.g., [fastq](https://www.npmjs.com/package/fastq)) and having the ability to retry not just failed asset uploads but also other parts of the CLI. I'm trying to upload an extensive library, and I have all kinds of network errors (I'm hosted with PikaPod, and my instance sometimes restarts, which makes the whole process crash). I think I will craft a draft for this and open a PR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label cli
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?