immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25686] feat: add people deeplink #18334

New Issue
Open
opened 2026-02-05 16:36:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:36:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25686
Author: @arne182
Created: 1/29/2026
Status: 🔄 Open

Base: main ← Head: patch-2

📝 Commits (4)

  • c27e2f7 Change path prefix from '/memories/' to '/people/'
  • a494beb Add regex for people deep link handling
  • 6333a0e Add deep link handling for 'people' route
  • 872fbb8 fix: missing person route builder method

📊 Changes

4 files changed (+40 additions, -5 deletions)

View changed files

📝 mobile/android/app/src/main/AndroidManifest.xml (+1 -1)
📝 mobile/lib/domain/services/people.service.dart (+4 -0)
📝 mobile/lib/infrastructure/repositories/people.repository.dart (+7 -0)
📝 mobile/lib/services/deep_link.service.dart (+28 -4)

📄 Description

Updated the AndroidManifest.xml to change the path prefix from '/memories/' to '/people/'. Memories is anyway wrong and was replaced by /memory and now the people path completes the known deeplinks.

Description

Fixes # (issue)

How Has This Been Tested?

  • https://my.immich.app/people/...

Screenshots (if appropriate)

Checklist:

  • [x ] I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

None
...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25686 **Author:** [@arne182](https://github.com/arne182) **Created:** 1/29/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `patch-2` --- ### 📝 Commits (4) - [`c27e2f7`](https://github.com/immich-app/immich/commit/c27e2f7f4798ea7ac244d337f79155d2ef4c1197) Change path prefix from '/memories/' to '/people/' - [`a494beb`](https://github.com/immich-app/immich/commit/a494bebb302129d7876f3cea716150d399895080) Add regex for people deep link handling - [`6333a0e`](https://github.com/immich-app/immich/commit/6333a0e9312a4bae61c8f9e6ea357337006ecd97) Add deep link handling for 'people' route - [`872fbb8`](https://github.com/immich-app/immich/commit/872fbb839d4acf555a0d1f94f651275edfa0e596) fix: missing person route builder method ### 📊 Changes **4 files changed** (+40 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `mobile/android/app/src/main/AndroidManifest.xml` (+1 -1) 📝 `mobile/lib/domain/services/people.service.dart` (+4 -0) 📝 `mobile/lib/infrastructure/repositories/people.repository.dart` (+7 -0) 📝 `mobile/lib/services/deep_link.service.dart` (+28 -4) </details> ### 📄 Description Updated the AndroidManifest.xml to change the path prefix from '/memories/' to '/people/'. Memories is anyway wrong and was replaced by /memory and now the people path completes the known deeplinks. ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Fixes # (issue) ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [ ] https://my.immich.app/people/... <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [x ] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [ ] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. None ... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:36:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18334
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?