immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25627] [MERGED] fix: escape handling #18322

New Issue
Closed
opened 2026-02-05 16:36:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:36:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25627
Author: @danieldietzler
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @jrasm91

Base: main ← Head: fix/escape-handling

📝 Commits (1)

📊 Changes

6 files changed (+56 additions, -80 deletions)

View changed files

📝 web/src/lib/components/timeline/TimelineAssetViewer.svelte (+0 -1)
📝 web/src/lib/components/timeline/actions/TimelineKeyboardActions.svelte (+32 -34)
📝 web/src/lib/modals/AlbumOptionsModal.svelte (+2 -1)
📝 web/src/lib/services/album.service.ts (+13 -3)
📝 web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte (+6 -33)
📝 web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte (+3 -8)

📄 Description

Escape handling was broken in various places around the web, especially when an AssetViewer is in play. Hopefully this should fix all of them

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25627 **Author:** [@danieldietzler](https://github.com/danieldietzler) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/escape-handling` --- ### 📝 Commits (1) - [`782f216`](https://github.com/immich-app/immich/commit/782f216370d29a0467f4e3e3b5b7d16b388eaff8) fix: escape handling ### 📊 Changes **6 files changed** (+56 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/timeline/TimelineAssetViewer.svelte` (+0 -1) 📝 `web/src/lib/components/timeline/actions/TimelineKeyboardActions.svelte` (+32 -34) 📝 `web/src/lib/modals/AlbumOptionsModal.svelte` (+2 -1) 📝 `web/src/lib/services/album.service.ts` (+13 -3) 📝 `web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+6 -33) 📝 `web/src/routes/(user)/people/[personId]/[[photos=photos]]/[[assetId=id]]/+page.svelte` (+3 -8) </details> ### 📄 Description Escape handling was broken in various places around the web, especially when an AssetViewer is in play. Hopefully this should fix all of them --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:36:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18322
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?