immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-15 21:32:32 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #25397] feat: mobile editing #18197

New Issue
Open
opened 2026-02-05 16:34:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 16:34:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/25397
Author: @bwees
Created: 1/20/2026
Status: 🔄 Open

Base: main ← Head: feat/mobile-editing

📝 Commits (10+)

  • 5bb6bcf feat: fix discriminated type parsing
  • 34b6e2c feat: mobile edits sync
  • 74297ec feat: send edit information on AssetEditReadyV1
  • 48f4282 fix: websocket backwards compatibility
  • 7acc0d5 fix: update assetEditReady event on web
  • 279e706 feat: working editor
  • 3a87746 chore: editor improvements
  • 128e798 fix: change condition for editable image
  • 8770cf0 chore: cleanup old filter page
  • bdc45da chore: cleanup edit import

📊 Changes

64 files changed (+11983 additions, -663 deletions)

View changed files

📝 i18n/en.json (+2 -0)
➕ mobile/drift_schemas/main/drift_schema_v18.json (+1 -0)
📝 mobile/lib/domain/models/asset/base_asset.model.dart (+2 -0)
➕ mobile/lib/domain/models/asset_edit.model.dart (+21 -0)
📝 mobile/lib/domain/models/exif.model.dart (+14 -0)
📝 mobile/lib/domain/services/asset.service.dart (+9 -0)
📝 mobile/lib/domain/services/sync_stream.service.dart (+23 -0)
➕ mobile/lib/infrastructure/entities/asset_edit.entity.dart (+32 -0)
➕ mobile/lib/infrastructure/entities/asset_edit.entity.drift.dart (+748 -0)
📝 mobile/lib/infrastructure/entities/exif.entity.dart (+2 -0)
📝 mobile/lib/infrastructure/repositories/db.repository.dart (+6 -1)
📝 mobile/lib/infrastructure/repositories/db.repository.drift.dart (+18 -4)
📝 mobile/lib/infrastructure/repositories/db.repository.steps.dart (+499 -0)
📝 mobile/lib/infrastructure/repositories/remote_asset.repository.dart (+35 -0)
📝 mobile/lib/infrastructure/repositories/sync_api.repository.dart (+3 -0)
📝 mobile/lib/infrastructure/repositories/sync_stream.repository.dart (+48 -2)
➕ mobile/lib/presentation/pages/drift_edit.page.dart (+476 -0)
➖ mobile/lib/presentation/pages/editing/drift_crop.page.dart (+0 -179)
➖ mobile/lib/presentation/pages/editing/drift_edit.page.dart (+0 -171)
➖ mobile/lib/presentation/pages/editing/drift_filter.page.dart (+0 -159)

...and 44 more files

📄 Description

Description

Support for the new editing system on mobile

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/25397 **Author:** [@bwees](https://github.com/bwees) **Created:** 1/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/mobile-editing` --- ### 📝 Commits (10+) - [`5bb6bcf`](https://github.com/immich-app/immich/commit/5bb6bcf70b4ce4bdecb939590c99424b92881218) feat: fix discriminated type parsing - [`34b6e2c`](https://github.com/immich-app/immich/commit/34b6e2ca994c432a980b2ea0cf0a3f0b5dac22ca) feat: mobile edits sync - [`74297ec`](https://github.com/immich-app/immich/commit/74297ec429dd8900fe071970afcaf6b90c663032) feat: send edit information on AssetEditReadyV1 - [`48f4282`](https://github.com/immich-app/immich/commit/48f4282056ba0ac1e1e901cd1ba9d038f4ede096) fix: websocket backwards compatibility - [`7acc0d5`](https://github.com/immich-app/immich/commit/7acc0d5c8225681b5dc44eef987ca139642af5e3) fix: update assetEditReady event on web - [`279e706`](https://github.com/immich-app/immich/commit/279e706c77e14a7b375deba7886ce284eccf2bec) feat: working editor - [`3a87746`](https://github.com/immich-app/immich/commit/3a87746ce629a2774cc47dd577e8ff865997fcc5) chore: editor improvements - [`128e798`](https://github.com/immich-app/immich/commit/128e798516819cbbd177f74dc0283230ead9b549) fix: change condition for editable image - [`8770cf0`](https://github.com/immich-app/immich/commit/8770cf0961327c982f1488be28ad65bc080810e6) chore: cleanup old filter page - [`bdc45da`](https://github.com/immich-app/immich/commit/bdc45da106837037ad80c0070feb9d4d0ee5e766) chore: cleanup edit import ### 📊 Changes **64 files changed** (+11983 additions, -663 deletions) <details> <summary>View changed files</summary> 📝 `i18n/en.json` (+2 -0) ➕ `mobile/drift_schemas/main/drift_schema_v18.json` (+1 -0) 📝 `mobile/lib/domain/models/asset/base_asset.model.dart` (+2 -0) ➕ `mobile/lib/domain/models/asset_edit.model.dart` (+21 -0) 📝 `mobile/lib/domain/models/exif.model.dart` (+14 -0) 📝 `mobile/lib/domain/services/asset.service.dart` (+9 -0) 📝 `mobile/lib/domain/services/sync_stream.service.dart` (+23 -0) ➕ `mobile/lib/infrastructure/entities/asset_edit.entity.dart` (+32 -0) ➕ `mobile/lib/infrastructure/entities/asset_edit.entity.drift.dart` (+748 -0) 📝 `mobile/lib/infrastructure/entities/exif.entity.dart` (+2 -0) 📝 `mobile/lib/infrastructure/repositories/db.repository.dart` (+6 -1) 📝 `mobile/lib/infrastructure/repositories/db.repository.drift.dart` (+18 -4) 📝 `mobile/lib/infrastructure/repositories/db.repository.steps.dart` (+499 -0) 📝 `mobile/lib/infrastructure/repositories/remote_asset.repository.dart` (+35 -0) 📝 `mobile/lib/infrastructure/repositories/sync_api.repository.dart` (+3 -0) 📝 `mobile/lib/infrastructure/repositories/sync_stream.repository.dart` (+48 -2) ➕ `mobile/lib/presentation/pages/drift_edit.page.dart` (+476 -0) ➖ `mobile/lib/presentation/pages/editing/drift_crop.page.dart` (+0 -179) ➖ `mobile/lib/presentation/pages/editing/drift_edit.page.dart` (+0 -171) ➖ `mobile/lib/presentation/pages/editing/drift_filter.page.dart` (+0 -159) _...and 44 more files_ </details> ### 📄 Description ## Description Support for the new editing system on mobile ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [ ] Test A - [ ] Test B <details><summary><h2>Screenshots (if appropriate)</h2></summary> <!-- Images go below this line. --> </details> <!-- API endpoint changes (if relevant) ## API Changes The `/api/something` endpoint is now `/api/something-else` --> ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation if applicable - [ ] I have no unrelated changes in the PR. - [ ] I have confirmed that any new dependencies are strictly necessary. - [ ] I have written tests for new code (if applicable) - [ ] I have followed naming conventions/patterns in the surrounding code - [ ] All code in `src/services/` uses repositories implementations for database calls, filesystem operations, etc. - [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services/`) ## Please describe to which degree, if any, an LLM was used in creating this pull request. ... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 16:34:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#18197
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?